Changes allowed cloud network to be updated by zone #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d-m-u Cannot apply the following label because they are not recognized: provisioning |
d-m-u
force-pushed
the
fixing_cloud_network
branch
2 times, most recently
from
1649992
to
fce8b45
Compare
|
@miq-bot assign @gmcculloug |
d-m-u
force-pushed
the
fixing_cloud_network
branch
2 times, most recently
from
9d950d6
to
9f661ac
Compare
d-m-u
force-pushed
the
fixing_cloud_network
branch
from
9f661ac
to
4097620
Compare
|
Checked commit d-m-u@4097620 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
d-m-u
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion of #16804, I think this should be reverted to the way it was before 16688 broke the provider subclass code
Previously, cloud network list was only updated after selection of security group, or change of tab, or a select set of other actions that completely voided the list of parameters passed to the filtering method. This adds a change so that availability zone updates the selection of cloud network, preventing incorrect cloud networks from showing up in the after the zone dropdown changes. This code should live in the specific provider that needs it though and that seems to only be Amazon afaik.
Should fix broken test in main and UI issue that Roman brought up (that 16804 also fixes but probably not correctly)
related to:
ManageIQ/manageiq#16806