Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Remove RestoreVmAttributes state #573

Conversation

ghost
Copy link

@ghost ghost commented Sep 2, 2019

The state machine is being ported to InfraConversionJob.
This PR is the counterpart of ManageIQ/manageiq#19240.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1748075
Depends on ManageIQ/manageiq#19240
Built on #572

@ghost
Copy link
Author

ghost commented Sep 2, 2019

@miq-bot add-label transformation, refactoring, ivanchuk/yes
@miq-bot add-reviewer @gmcculloug
@miq-bot add-reviewer @tinaafitz

@coveralls
Copy link

coveralls commented Sep 2, 2019

Pull Request Test Coverage Report for Build 3536

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 96.794%

Totals Coverage Status
Change from base Build 3535: -0.09%
Covered Lines: 2838
Relevant Lines: 2932

💛 - Coveralls

@miq-bot
Copy link
Member

miq-bot commented Sep 2, 2019

Checked commits fabiendupont/manageiq-content@6777816~...1ee1569 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@ghost
Copy link
Author

ghost commented Sep 10, 2019

Dependent PR has been merged.

@gmcculloug gmcculloug merged commit 519e0a9 into ManageIQ:master Sep 11, 2019
@gmcculloug gmcculloug added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 11, 2019
@ghost ghost deleted the v2v_state_machine_restore_vm_attributes branch September 11, 2019 14:00
simaishi pushed a commit that referenced this pull request Nov 4, 2019
…_vm_attributes

[V2V] Remove RestoreVmAttributes state

(cherry picked from commit 519e0a9)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768524
@simaishi
Copy link
Contributor

simaishi commented Nov 4, 2019

Ivanchuk backport details:

$ git log -1
commit 0cf513156c03f434b00ba7785a0769cc84f11b05
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Sep 11 09:48:55 2019 -0400

    Merge pull request #573 from fdupont-redhat/v2v_state_machine_restore_vm_attributes
    
    [V2V] Remove RestoreVmAttributes state
    
    (cherry picked from commit 519e0a9197d4d7492b5c220b206d8146a59eff4c)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768524

@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2019

The backport reverted

commit 07d176c485af199d3c463fbf69b01f9048b3909e
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Tue Dec 3 11:11:52 2019 -0500

    Revert "Merge pull request #573 from fdupont-redhat/v2v_state_machine_restore_vm_attributes"

    This reverts commit 0cf513156c03f434b00ba7785a0769cc84f11b05.

    https://bugzilla.redhat.com/show_bug.cgi?id=1768524

simaishi pushed a commit that referenced this pull request Feb 21, 2020
…_vm_attributes

[V2V] Remove RestoreVmAttributes state

(cherry picked from commit 519e0a9)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768524
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit bad9069f794a685aacf8da18d2f0f52713495feb
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Sep 11 09:48:55 2019 -0400

    Merge pull request #573 from fdupont-redhat/v2v_state_machine_restore_vm_attributes

    [V2V] Remove RestoreVmAttributes state

    (cherry picked from commit 519e0a9197d4d7492b5c220b206d8146a59eff4c)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants