[V2V] Add restoring_vm_attributes state to InfraConversionJob #19240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
This was referenced Sep 2, 2019
djberg96
reviewed
Sep 10, 2019
app/models/infra_conversion_job.rb
Outdated
| def apply_right_sizing_memory(mode) | ||
| destination_vm.set_memory(source_vm.send("#{mode}_recommended_mem")) | ||
| end | ||
|
|
There was a problem hiding this comment.
Aren't these already in #19238? Not a big deal, just thought it was odd.
|
@fdupont-redhat seems like you mixed in a lot of identical code from #19238 which is making this a little difficult to review. |
ghost
force-pushed
the
v2v_state_machine_restore_vm_attributes
branch
from
fb0987e
to
9f57a48
Compare
|
@miq-bot remove-label unmergeable |
|
Checked commits fabiendupont/manageiq@ff66fba~...9f57a48 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
djberg96
approved these changes
Sep 10, 2019
agrare
approved these changes
Sep 10, 2019
simaishi
pushed a commit
that referenced
this pull request
Nov 4, 2019
…re_vm_attributes [V2V] Add restoring_vm_attributes state to InfraConversionJob (cherry picked from commit 399ea75) https://bugzilla.redhat.com/show_bug.cgi?id=1768524
|
Ivanchuk backport details: |
simaishi
added a commit
that referenced
this pull request
Dec 3, 2019
…ne_restore_vm_attributes" This reverts commit b752d4e. https://bugzilla.redhat.com/show_bug.cgi?id=1768524
|
Reverted the backport |
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
…re_vm_attributes [V2V] Add restoring_vm_attributes state to InfraConversionJob (cherry picked from commit 399ea75) https://bugzilla.redhat.com/show_bug.cgi?id=1768524
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IMS 1.3 we're moving state machine handling from automate into core. For ease of writing and review, we're breaking this down into (hopefully) easily digestible bits, one state at a time. Each PR will ultimately have a corresponding PR in manageiq-content that deletes the relevant bit of code from automate.
Original automate code:
https://github.com/ManageIQ/manageiq-content/blob/master/content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/restorevmattributes.rb
This PR adds restoring_vm_attributes state to the state machine. The state machine is changed to allow transition from applying_right_sizing.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1748075
Depends on #19149, #19150, #19154, #19177, #19200, #19216, #19222, #19230, #19238
Built on #19238