[V2V] Update Transformation Task in InfraConversionJob #19154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label transformation, refactoring, ivanchuk/yes, wip |
miq-bot
changed the title
djberg96
reviewed
Aug 15, 2019
ghost
changed the title
ghost
force-pushed
the
v2v_infraconversionjob_update_task_status
branch
from
cb338b0
to
fe7d59a
Compare
|
Checked commits fabiendupont/manageiq@b84d398~...c3941c4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
miq-bot
changed the title
ghost
mentioned this pull request
agrare
approved these changes
Aug 23, 2019
agrare
added a commit
that referenced
this pull request
Aug 23, 2019
…update_task_status [V2V] Update Transformation Task in InfraConversionJob
ghost
mentioned this pull request
This was referenced Aug 28, 2019
simaishi
pushed a commit
that referenced
this pull request
Oct 31, 2019
…update_task_status [V2V] Update Transformation Task in InfraConversionJob (cherry picked from commit 22d2201) https://bugzilla.redhat.com/show_bug.cgi?id=1767637
|
Ivanchuk backport details: |
simaishi
added a commit
that referenced
this pull request
Dec 3, 2019
…sionjob_update_task_status" This reverts commit e390b1a. https://bugzilla.redhat.com/show_bug.cgi?id=1767637
|
Reverted the backport |
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
…update_task_status [V2V] Update Transformation Task in InfraConversionJob (cherry picked from commit 22d2201) https://bugzilla.redhat.com/show_bug.cgi?id=1767637
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to port the
WeightedUpdateStatusmethod to InfraConversionJob. The goal of the method is to update the ServiceTemplateTransformationPlanTask at each transition, so that the UI can display the information.This PR introduces a new hash,
states, that stores information about the states:description,weightandmax_retries. These fields are used to update the task. Currently, onlypolling_timeoutleverages this new hash. It has been changed to usemax_retries.We consider that a state has 4 hooks:
on_entry- the state starts running, including retrieson_retry- the state exits and the transition doesn't change the stateon_exit- the state exits and the transition changes the stateon_error- the state has failedThe
update_migration_task_progressmethod generates a state hash with:state,status,message,percent,started_onandupdated_on. Each hook can alter one or more attributes of the state hash. The state hash is then used to update the migration task progress.This PR also simplifies
poll_conversionandpoll_post_stagemethod that shouldn't interfere with Automate methods. They are meant to only monitor virt-v2v and post-migration phases of the migration task. These methods will be updated when we portVMTransform,VMCheckTransformedmethods, as well as the methods inPostTransform.RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1740659
Built on #19149, #19164