Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the user to specify image tags/digests for the worker images #557

Closed
carbonin opened this issue Jun 19, 2020 · 0 comments · Fixed by #558
Closed

Allow the user to specify image tags/digests for the worker images #557

carbonin opened this issue Jun 19, 2020 · 0 comments · Fixed by #558
Assignees
@carbonin
Labels
enhancement operator

Comments

@carbonin
Copy link
Member

Right now we can configure the image for all the "operands" with parameters to the CR, but the workers deployed by the orchestrator are always bound to the orchestrator's tag.

This is a problem if the orchestrator is tagged differently or pulled using a sha so we should allow users to specify image strings for the manageiq-base-worker, manageiq-webserver-worker and manageiq-ui-worker images through the operator.

This will also require some changes on the manageiq side to pull the env vars and use them when deploying the workers.

cc @Fryguy
@carbonin carbonin self-assigned this Jun 19, 2020
carbonin added a commit to carbonin/manageiq that referenced this issue Jun 19, 2020
@carbonin
Create env vars to override the full worker image ref
a9df77a 
This will allow advanced users more flexability in how
the worker images are specified. Specifically this allows
changing the image name itself and also allows for digest-based
identifiers (rather than using only tags)

Applies to ManageIQ/manageiq-pods#557
@carbonin carbonin mentioned this issue Jun 19, 2020
Merged
carbonin added a commit to carbonin/manageiq that referenced this issue Jun 19, 2020
@carbonin
Create env vars to override the full worker image ref
3b51664 
This will allow advanced users more flexability in how
the worker images are specified. Specifically this allows
changing the image name itself and also allows for digest-based
identifiers (rather than using only tags)

Applies to ManageIQ/manageiq-pods#557
carbonin added a commit to carbonin/manageiq-pods that referenced this issue Jun 19, 2020
@carbonin
Add an override for the worker images deployed by the orchestrator
e0a5341 
Previously a user was not able to change the actual image name for
the worker images nor were they able to deploy with anything other
than the namespace and tag deployed for the orchestrator.

This gives a bit more flexability in that one image can be replaced
at a time and also allows a user to specify an image ref with a
digest rather than a tag

Fixes ManageIQ#557
@carbonin carbonin mentioned this issue Jun 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carbonin carbonin

Labels
enhancement operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an override for the worker images deployed by the orchestrator carbonin/manageiq-pods
1 participant
@carbonin