Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create env vars to override the full worker image ref #20297

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

carbonin
Copy link
Member

This will allow advanced users more flexability in how
the worker images are specified. Specifically this allows
changing the image name itself and also allows for digest-based
identifiers (rather than using only tags)

Applies to ManageIQ/manageiq-pods#557

This will allow advanced users more flexability in how
the worker images are specified. Specifically this allows
changing the image name itself and also allows for digest-based
identifiers (rather than using only tags)

Applies to ManageIQ/manageiq-pods#557
@miq-bot
Copy link
Member

miq-bot commented Jun 19, 2020

Checked commit carbonin@3b51664 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
4 files checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy Fryguy merged commit 76aefb0 into ManageIQ:master Jun 19, 2020
@carbonin carbonin deleted the env_for_full_image_ref branch June 19, 2020 19:19
simaishi pushed a commit that referenced this pull request Jun 23, 2020
Create env vars to override the full worker image ref

(cherry picked from commit 76aefb0)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit e33a8f3fd8665356334b5c61976fed84902d3bc0
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Jun 19 15:09:47 2020 -0400

    Merge pull request #20297 from carbonin/env_for_full_image_ref

    Create env vars to override the full worker image ref

    (cherry picked from commit 76aefb0bee8c834a6d26c609d66e87599adb0f78)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants