Remove require_nested :Runner from NetworkManager::EventCatcher and NetworkManager::MetricsCollectorWorker
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the Amazon::NetworkManager::EventCatcher and Amazon::NetworkManager::MetricsCollectorWorker don't have corresponding nested event_catcher/runner.rb and metrics_collector_worker/runner.rb directories respectively, thus `require_nested` fails. The reason this doesn't seem to be a problem is we don't eager load in manageiq, and it is possible that these two classes are currently not in use.
|
Checked commit NickLaMuro@991b550 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
good catch, seems to me that this fix is sufficient 👍 |
|
@NickLaMuro this doesn't need to go to Euwe, right? |
|
@Ladas Depends on a few things, both of which I am unsure about:
We can leave it |
|
Also, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid issues in development mode when eager loading, since this doesn't work.
Background
As part of ManageIQ/manageiq#14261 I am trying to get
eager_loadingfuctioning properly withmanageiq. When doing eager loading in development mode, things bust becauserequire_nestedon these two models is invalid because there isn't a corresponding nested directory available for these two models.Not sure the status of these models, because they aren't included in the main
NetworkManagerin this provider, so they might be incomplete or not used. Only eager loading without cached classes seems to cause this error to, so I will let the reviewer be the judge of whether this fix is sufficient, or we should consider removing these models entirely.Links