Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove require_nested :Runner from NetworkManager::EventCatcher and NetworkManager::MetricsCollectorWorker #173

Merged
merged 1 commit into from
Mar 13, 2017
Merged

Remove require_nested :Runner from NetworkManager::EventCatcher and NetworkManager::MetricsCollectorWorker #173

merged 1 commit into from
Mar 13, 2017

Commits on Mar 11, 2017

  1. Remove require_nested :Runner from two invalid models 

    Both the Amazon::NetworkManager::EventCatcher and
Amazon::NetworkManager::MetricsCollectorWorker don't have corresponding
nested event_catcher/runner.rb and metrics_collector_worker/runner.rb
directories respectively, thus `require_nested` fails.

The reason this doesn't seem to be a problem is we don't eager load in
manageiq, and it is possible that these two classes are currently not in
use.
    @NickLaMuro
    NickLaMuro committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    991b550 View commit details
    Browse the repository at this point in the history