[WIP] initial stab at comparing available instance types

[durandom]

with those listed at ec2instances.info.

Right now it does not compare all attributes, but at least it finds new instance types.
We could add the content from ec2instances.info to a vcr or even better fetch it live on CI.
This could be a reference for other providers as well.

❯ be rspec spec/models/manageiq/providers/amazon/instance_types_spec.rb
** master - DB vmdb_test on

Randomized with seed 35266
"m2.xlarge" => {
:description => "M2 High Memory Extra Large"
# was: M2 High-Memory Extra Large
}
"m2.2xlarge" => {
:description => "M2 High Memory Double Extra Large"
# was: M2 High-Memory Double Extra Large
}
"m2.4xlarge" => {
:description => "M2 High Memory Quadruple Extra Large"
# was: M2 High-Memory Quadruple Extra Large
}
"cr1.8xlarge" => {
:description => "High Memory Cluster Eight Extra Large"
# was: High-Memory Cluster Eight Extra Large
}
"hi1.4xlarge" => {
:description => "HI1. High I/O Quadruple Extra Large"
# was: High I/O Quadruple Extra Large
}
"t1.micro" => {
:family => "Micro"
# was: Micro Instances
}
"m4.large" => {
:description => "M4 Large"
# was: M4 General Purpose Large
}
"m4.xlarge" => {
:description => "M4 Extra Large"
# was: M4 General Purpose Extra Large
}
"m4.2xlarge" => {
:description => "M4 Double Extra Large"
# was: M4 General Purpose Double Extra Large
}
"m4.4xlarge" => {
:description => "M4 Quadruple Extra Large"
# was: M4 General Purpose Quadruple Extra Large
}
"m4.10xlarge" => {
:description => "M4 Deca Extra Large"
# was: M4 General Purpose Ten Extra Large
}
.

[miq-bot]

<github_pr_commenter_batch />Some comments on commit durandom@0b88aab

spec/models/manageiq/providers/amazon/instance_types_spec.rb

• ⚠️ - 43 - Detected puts. Remove all debugging statements.
• ⚠️ - 47 - Detected puts. Remove all debugging statements.
• ⚠️ - 48 - Detected puts. Remove all debugging statements.
• ⚠️ - 51 - Detected puts. Remove all debugging statements.
• ⚠️ - 54 - Detected puts. Remove all debugging statements.

[miq-bot]

Some comments on commits durandom/manageiq-providers-amazon@903167b~...154b35b

spec/models/manageiq/providers/amazon/instance_types_spec.rb

• ⚠️ - 109 - Detected puts. Remove all debugging statements.
• ⚠️ - 161 - Detected puts. Remove all debugging statements.

[miq-bot]

Checked commits durandom/manageiq-providers-amazon@903167b~...154b35b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 12 offenses detected

spec/models/manageiq/providers/amazon/instance_types_spec.rb

• ⚠️ - Line 74, Col 9 - Lint/EndAlignment - end at 74, 8 is not aligned with case at 69, 34.
• ❗ - Line 112, Col 1 - Style/EmptyLines - Extra blank line detected.
• ❗ - Line 113, Col 1 - Style/EmptyLines - Extra blank line detected.
• ❗ - Line 145, Col 25 - Style/PreferredHashMethods - Use Hash#key? instead of Hash#has_key?.
• ❗ - Line 153, Col 25 - Style/PreferredHashMethods - Use Hash#key? instead of Hash#has_key?.
• ❗ - Line 163, Col 1 - Style/EmptyLinesAroundBlockBody - Extra empty line detected at block body end.
• ❗ - Line 166, Col 1 - Style/EmptyLinesAroundBlockBody - Extra empty line detected at block body end.
• ❗ - Line 70, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• ❗ - Line 73, Col 52 - Style/SpaceAfterComma - Space missing after comma.
• ❗ - Line 76, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• ❗ - Line 88, Col 1 - Style/EmptyLines - Extra blank line detected.
• ❗ - Line 93, Col 1 - Style/EmptyLines - Extra blank line detected.

[durandom]

closing in favour of #170