-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain instance types #170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
includes #171 |
❯ bin/rails providers:amazon:instance_types Created ./instance_types.rb with 21 new, 4 newly deprecated and 0 new discontinued instances. Now copy it to the existing one: mv instance_types.rb app/models/manageiq/providers/amazon/instance_types.rb
durandom
force-pushed
the
maintain_instance_types
branch
from
March 9, 2017 15:19
7c47765
to
fe7e753
Compare
durandom
force-pushed
the
maintain_instance_types
branch
from
March 9, 2017 16:40
fe7e753
to
36effca
Compare
Some comments on commits durandom/manageiq-providers-amazon@69db2fc~...36effca lib/tasks/instance_types.rake
|
Checked commits durandom/manageiq-providers-amazon@69db2fc~...36effca with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manageiq/providers/amazon/instance_types.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes data from
and creates a new
instance_types.rb
file to be copied overapp/models/manageiq/providers/amazon/instance_types.rb
It can be run via a rake task
It maintains order of the current instances.
NOTE: I havent found a better place than a rake task for this. I started out with a spec, but specs should not create files. Then a
tools/
script, but I can'trails runner
in an engine. Now it's a task.For this, I had to load a engine tasks in the Rakefile. I opted to put them under the
providers:amazon
namespace, because they are also loaded in the core repoIf you want I could split this into 2 PRs
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427966
cc @bronaghs @Fryguy @blomquisg