-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back an instance_types rake task #707
Conversation
:memory: 17179869184 | ||
:memory_gb: 16.0 | ||
:name: a1.2xlarge | ||
:network_performance: :up_to_10_gigabit | ||
:network_performance: :very_high |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a legit bug in the current yaml, the network performance string is "Up To 10 Gigabit" which didn't match our exact "10 Gigabit" or "20 Gigabit" check
de5b1a1
to
34e3729
Compare
Overall LGTM - glad the script is relatively tiny. |
83a2d44
to
7ff2680
Compare
For now I've limited this to just the existing flavors so that the diff cleaner and it is more obvious what is changed by specifically this generator. I will follow-up with the new flavors that have been added since this was last run in a separate PR. |
7ff2680
to
5605751
Compare
Checked commit agrare@5605751 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint lib/tasks_private/instance_types.rake
|
Backported to
|
Add back an instance_types rake task (cherry picked from commit 216036c)
There used to be a rake task to auto-generate the instance_types.rb (at least as early as #170)
It was removed in #449 with the plan of pulling this info from the AWS API/SDK however that never materialized.
This manifested in provisioning failing because the
vpc_only
attribute was flat out incorrect for a number of flavors which caused the auto-select logic to fail.