Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inherit_from to use local .rubocop_base.yml #78

Closed

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Nov 9, 2016

[skip ci]

@Fryguy
Copy link
Member

Fryguy commented Nov 9, 2016

cc @durandom We should probably change the generator to make the rubocop configs consistent. Please discuss with @jrafanie the best way to do this.

@miq-bot
Copy link
Member

miq-bot commented Nov 9, 2016

Checked commit jrafanie@c56f41a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. ⭐

@durandom
Copy link
Member

I changed that in my generator PR ManageIQ/manageiq#12209 which is yet to be merged.

I dont see another way to propagate changes from miq/.rubocop_base.yml than running the generator again and applying that patch.

This change is also in my PR to bring this repo in line with the generator output #71

@Fryguy
Copy link
Member

Fryguy commented Nov 11, 2016

Closing since this line is part of #71, and I'd prefer merging it in with that.

@Fryguy Fryguy closed this Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants