generator for providers #12209

durandom · 2016-10-26T15:50:29Z

creates an empty provider at providers/<provider_name>
use as rails generate provider UberCloud

@miq-bot add_labels pluggable providers
@miq-bot assign Fryguy

cc @juliancheal @blomquisg @Ladas

juliancheal · 2016-10-26T16:10:44Z

Oh poor @miq-bot. Is this the first template we've created?

Can't see any cops we can add to Rubocop to validate erb in .rb files.

Fryguy · 2016-10-26T20:33:57Z

We can add this whole directory to the excludes list, probably.

Fryguy · 2016-10-26T20:34:09Z

Also 😮 😮 😮 😮 Very excited!!

Fryguy · 2016-10-26T20:34:45Z

lib/generators/provider/provider_generator.rb

@@ -0,0 +1,59 @@
+require "rails/generators/rails/app/app_generator"
+class ProviderGenerator < Rails::Generators::NamedBase
+  source_root File.expand_path('../templates', __FILE__)


Prefer File.expand_path("templates", __dir__)

Fryguy · 2016-10-26T20:36:57Z

lib/generators/provider/templates/app/models/manageiq/providers/cloud_manager.rb

@@ -0,0 +1,2 @@
+class ManageIQ::Providers::<% class_name %>::CloudManager < ManageIQ::Providers::CloudManager


Should this be <%= vs <%

Fryguy · 2016-10-26T20:37:19Z

lib/generators/provider/templates/bin/setup

+APP_ROOT = Pathname.new File.expand_path('../../',  __FILE__)
+
+Dir.chdir APP_ROOT do
+  if File.exists?("spec/manageiq")


Rubocop: File.exists? is deprecated in favor of File.exist?.

Pasting CodeClimate? 😛 But thanks.

Fryguy · 2016-10-26T20:39:41Z

lib/generators/provider/templates/tools/ci/before_install.sh

+export BUNDLE_WITHOUT=development
+export BUNDLE_GEMFILE=${PWD}/Gemfile
+
+set +v


It would be nice if we could keep super-common stuff like this in the ManageIQ repo, and then refer to it somehow. Like, perhaps keep the git clone and then have the rest of the file live in ManageIQ/tools/ci somewhere?

The more that's duplicated across provider repos, the more it has to be fixed across the board.

agreed. I'll see what I can do.

OTOH, whats nice about the generator: you can run it again and have it patch the files in the repos

Fryguy · 2016-10-26T20:40:10Z

lib/generators/provider/templates/README.md

+[![Code Climate](https://codeclimate.com/github/ManageIQ/manageiq-providers-<%= provider_name %>.svg)](https://codeclimate.com/github/ManageIQ/manageiq-providers-<%= provider_name %>)
+[![Test Coverage](https://codeclimate.com/github/ManageIQ/manageiq-providers-<%= provider_name %>/badges/coverage.svg)](https://codeclimate.com/github/ManageIQ/manageiq-providers-<%= provider_name %>/coverage)
+[![Dependency Status](https://gemnasium.com/ManageIQ/manageiq-providers-<%= provider_name %>.svg)](https://gemnasium.com/ManageIQ/manageiq-providers-<%= provider_name %>)
+[![Security](https://hakiri.io/github/ManageIQ/manageiq-providers-<%= provider_name %>/master.svg)](https://hakiri.io/github/ManageIQ/manageiq-providers-<%= provider_name %>/master)


Where's the zanata badge.

there it is now. 👇

Fryguy · 2016-10-26T20:42:09Z

creates an empty provider at providers/<provider_name>

Wonder if it should create it at ../manageiq-providers-provider_name (and then also git init in that directory if possible.

Fryguy · 2016-10-26T20:42:24Z

This is really great stuff @durandom !!

Fryguy · 2016-10-27T17:32:12Z

lib/generators/provider/templates/.travis.yml

+notifications:
+  webhooks:
+    urls:
+    - https://webhooks.gitter.im/e/7af45001fe6b7a4039f2


This is a webhook for a specific gitter channel, so this should not be in the template.

djberg96 · 2016-10-27T21:01:28Z

@durandom Wouldn't it be easier to develop and maintain this as a rails plugin in its own repo rather than baked into ManageIQ directly?

Fryguy · 2016-10-27T21:18:05Z

I'm ok with it starting here and extracting afterwards.

durandom · 2016-10-28T07:18:11Z

@djberg96 I totally agree with you, but in order to get this jumpstarted I implemented it here first. This gives us CI and other stuff. I also need it quite soon to extract the other providers.

If you want to help out on doing this you are more than welcome 😄

durandom · 2016-10-28T13:04:53Z

@jrafanie can you have a look at the split of tools/ci/ scripts here? This is done to call those bits as needed from a provider repo.

If ok, I can extract them to their own PR.

durandom · 2016-10-28T13:05:43Z

ManageIQ/manageiq-providers-amazon#71 applies the output to the manageiq repo and CI is still working there

jrafanie · 2016-10-28T16:15:25Z

tools/ci/setup_vmdb_configs.sh

+cp config/database.pg.yml config/database.yml
+cp config/cable.yml.sample config/cable.yml
+psql -c "CREATE USER root SUPERUSER PASSWORD 'smartvm';" -U postgres
+


Looks good @durandom 👍

If these changes work, it's good to bucket these various setups into categories.

jrafanie · 2016-10-28T16:16:49Z

@jrafanie can you have a look at the split of tools/ci/ scripts here? This is done to call those bits as needed from a provider repo.

If ok, I can extract them to their own PR.

👍 I like it. My only concern that seems to keep creeping in is ways to keep your copied templates in sync with any changes we make in MIQ. We probably need some ways to keep repos in sync since we'll be routinely copying content to new repos from old locations.

jrafanie · 2016-10-28T16:19:50Z

@durandom this PR is solid "Like a rock, like a planet"

durandom · 2016-10-28T17:44:47Z

Like a rock, like a planet

like a f*** 💣

durandom · 2016-11-09T11:56:00Z

@Fryguy its green, merge?

creates an empty provider at providers/<provider_name> use as rails generate provider

miq-bot · 2016-12-07T19:11:21Z

<github_pr_commenter_batch />Some comments on commits durandom/manageiq@4a72236~...141d49b

lib/generators/provider/templates/Rakefile

⚠️ - 4 - Detected puts. Remove all debugging statements.

lib/generators/provider/templates/bin/setup

⚠️ - 12 - Detected puts. Remove all debugging statements.
⚠️ - 16 - Detected puts. Remove all debugging statements.
⚠️ - 21 - Detected puts. Remove all debugging statements.
⚠️ - 26 - Detected puts. Remove all debugging statements.
⚠️ - 9 - Detected puts. Remove all debugging statements.

miq-bot · 2016-12-07T19:12:23Z

Checked commits durandom/manageiq@4a72236~...141d49b with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 3 offenses detected

lib/generators/provider/provider_generator.rb

❕ - Line 14, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for create_files is too high. [29/20]
❕ - Line 14, Col 3 - Metrics/MethodLength - Method has too many lines. [27/25]
❕ - Line 50, Col 121 - Metrics/LineLength - Line is too long. [163/120]

durandom · 2016-12-07T20:42:18Z

@jrafanie do you dare to merge this? 😈

jrafanie · 2016-12-08T15:04:47Z

While I like the templates, I wonder if the generator could fetch the latest versions of the templates from the main repo, where the templates in this PR are identical with the main repos... Either way, we can do that later. I've seen it all along, LGTM.

durandom · 2016-12-08T15:30:34Z

@jrafanie thanks for merging 🎉

Will try to address your concerns / ideas in follow ups

miq-bot added the pluggability/providers label Oct 26, 2016

miq-bot assigned Fryguy Oct 26, 2016

miq-bot added the dependencies label Oct 26, 2016

Fryguy reviewed Oct 26, 2016

View reviewed changes

Fryguy added enhancement euwe/no labels Oct 26, 2016

chessbyte added the wip label Oct 26, 2016

durandom force-pushed the provider_generator branch from 786aebe to 96fc0ee Compare October 27, 2016 15:30

Fryguy reviewed Oct 27, 2016

View reviewed changes

durandom force-pushed the provider_generator branch 3 times, most recently from 9e2e920 to 5d59d3e Compare October 28, 2016 12:17

jrafanie reviewed Oct 28, 2016

View reviewed changes

durandom force-pushed the provider_generator branch 5 times, most recently from 8c9cdf5 to a78859c Compare November 9, 2016 10:33

durandom force-pushed the provider_generator branch 7 times, most recently from d2de7e0 to 8f3c7d8 Compare November 10, 2016 09:37

durandom mentioned this pull request Nov 10, 2016

Update inherit_from to use local .rubocop_base.yml ManageIQ/manageiq-providers-amazon#78

Closed

durandom force-pushed the provider_generator branch from 8f3c7d8 to 255bfa7 Compare November 11, 2016 14:04

durandom added 2 commits December 5, 2016 17:53

ignore templates folder in rubocop config

4a72236

ignore templates folder in coverage_helper

cb2d04c

durandom force-pushed the provider_generator branch 2 times, most recently from d17de54 to 55c6209 Compare December 7, 2016 15:20

generator for providers

141d49b

creates an empty provider at providers/<provider_name> use as rails generate provider

durandom force-pushed the provider_generator branch from 55c6209 to 141d49b Compare December 7, 2016 19:09

jrafanie merged commit 744abc5 into ManageIQ:master Dec 8, 2016

jrafanie added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 8, 2016

durandom deleted the provider_generator branch December 8, 2016 21:38

durandom mentioned this pull request Apr 21, 2017

Pluggable Providers TODO #14840

Closed

38 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

generator for providers #12209

generator for providers #12209

durandom commented Oct 26, 2016 •

edited by miq-bot

Loading

juliancheal commented Oct 26, 2016 •

edited

Loading

Fryguy commented Oct 26, 2016

Fryguy commented Oct 26, 2016

Fryguy Oct 26, 2016

Fryguy Oct 26, 2016

Fryguy Oct 26, 2016

durandom Oct 27, 2016

Fryguy Oct 26, 2016

durandom Oct 27, 2016

Fryguy Oct 26, 2016 •

edited

Loading

durandom Oct 27, 2016

Fryguy commented Oct 26, 2016

Fryguy commented Oct 26, 2016

Fryguy Oct 27, 2016

djberg96 commented Oct 27, 2016

Fryguy commented Oct 27, 2016

durandom commented Oct 28, 2016

durandom commented Oct 28, 2016

durandom commented Oct 28, 2016

jrafanie Oct 28, 2016

jrafanie commented Oct 28, 2016

jrafanie commented Oct 28, 2016

durandom commented Oct 28, 2016

durandom commented Nov 9, 2016

miq-bot commented Dec 7, 2016

miq-bot commented Dec 7, 2016

durandom commented Dec 7, 2016

jrafanie commented Dec 8, 2016

durandom commented Dec 8, 2016

		@@ -0,0 +1,2 @@
		class ManageIQ::Providers::<% class_name %>::CloudManager < ManageIQ::Providers::CloudManager

generator for providers #12209

generator for providers #12209

Conversation

durandom commented Oct 26, 2016 • edited by miq-bot Loading

juliancheal commented Oct 26, 2016 • edited Loading

Fryguy commented Oct 26, 2016

Fryguy commented Oct 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fryguy Oct 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fryguy commented Oct 26, 2016

Fryguy commented Oct 26, 2016

Choose a reason for hiding this comment

djberg96 commented Oct 27, 2016

Fryguy commented Oct 27, 2016

durandom commented Oct 28, 2016

durandom commented Oct 28, 2016

durandom commented Oct 28, 2016

Choose a reason for hiding this comment

jrafanie commented Oct 28, 2016

jrafanie commented Oct 28, 2016

durandom commented Oct 28, 2016

durandom commented Nov 9, 2016

miq-bot commented Dec 7, 2016

miq-bot commented Dec 7, 2016

durandom commented Dec 7, 2016

jrafanie commented Dec 8, 2016

durandom commented Dec 8, 2016

durandom commented Oct 26, 2016 •

edited by miq-bot

Loading

juliancheal commented Oct 26, 2016 •

edited

Loading

Fryguy Oct 26, 2016 •

edited

Loading