moving settings from manageiq #91
Conversation
durandom
force-pushed
the
settings
branch
2 times, most recently
from
91abacd
to
6b12ae6
Compare
| # :spec-region-1: | ||
| # :name: Special Region | ||
| # :hostname: ec2.spec-region-1.amazonaws.com | ||
| # :description: Super Special Region |
There was a problem hiding this comment.
@agrare I added this as dummy example
|
@blomquisg care to merge this? |
| :ems_amazon: | ||
| :disabled_regions: [] | ||
| # disable regions by their keys found in app/models/manageiq/providers/amazon/regions.rb e.g. | ||
| # uncomment the following to disable gov-west-1 region |
There was a problem hiding this comment.
I would remove this statement. We don't want users editing this file at all. Instead they would go either go through Advanced Settings (which stores the changes in the database) or we would have them deploy a settings.local.yml or something.
There was a problem hiding this comment.
Note that this comment will not appear in Advanced Settings, so who is the audience for this comment?
There was a problem hiding this comment.
You are right about the uncomment statement.
Note that this comment will not appear in Advanced Settings
Yeah, I know, but I havent found a better place to add some configuration hints. Same as here
I think it's better than nothing. And advanced users might find their way by googleing or looking at the source. And if its only support staff of ours.
Would it be better to approach the docs team to add that to the docs?
There was a problem hiding this comment.
Yeah I was just thinking docs. That seems the most appropriate place to document new settings. You may be able to contribute directly in https://github.com/ManageIQ/manageiq_docs, particularly if they already have section somewhere for Advanced Settings.
There was a problem hiding this comment.
Ok, will open a PR to that repo 👍
|
Checked commits durandom/manageiq-providers-amazon@bf6b305~...d2b3710 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
I will remove the settings from manageiq/config/settings.yml once this is merged