move amazon settings to ManageIQ/manageiq-providers-amazon #13192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
|
ManageIQ/manageiq-providers-amazon#91 is merged so this needs a rebase. |
Fryguy
requested changes
Jan 6, 2017
| :disabled_regions: [] | ||
| :additional_regions: {} | ||
| :ems_azure: | ||
| :disabled_regions: [] |
There was a problem hiding this comment.
I think you shouldn't have removed azure here.
durandom
force-pushed
the
amazon_settings
branch
from
8d9f881
to
90d7ce6
Compare
durandom
changed the title
|
@miq-bot remove_label wip |
|
Checked commit durandom@90d7ce6 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@Fryguy its green now, merge? |
|
This looks good to me. Anything else Eagle Eye @Fryguy can catch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving amazon specific settings to
once ManageIQ/manageiq-providers-amazon#91 is merged, this should be good to go
@miq-bot assign @blomquisg
@miq-bot add_labels providers/amazon, pluggable providers, enhancement, euwe/no