Merge pull request #25 from bronaghs/floating_ip_available_method_change

Return the available Floating IPs in Azure.

app/models/manageiq/providers/azure/network_manager.rb

@@ -17,6 +17,9 @@ class ManageIQ::Providers::Azure::NetworkManager < ManageIQ::Providers::NetworkM
 
   include ManageIQ::Providers::Azure::ManagerMixin
 
+  has_many :floating_ips, :foreign_key => :ems_id, :dependent => :destroy,
+           :class_name => ManageIQ::Providers::Azure::NetworkManager::FloatingIp
+
   # Auth and endpoints delegations, editing of this type of manager must be disabled
   delegate :authentication_check,
            :authentication_status,

app/models/manageiq/providers/azure/network_manager/floating_ip.rb

@@ -1,2 +1,5 @@
 class ManageIQ::Providers::Azure::NetworkManager::FloatingIp < ::FloatingIp
+  def self.available
+    joins(:network_port).where("network_ports.device_id" => nil) + where(:network_port_id => nil)
+  end
 end

spec/models/manageiq/providers/azure/cloud_manager/provision_workflow_spec.rb

@@ -53,6 +53,34 @@
         end
       end
     end
+
+    context "floating ips" do
+      before do
+        FactoryGirl.create(:network_port_azure, :id => 1, :device_id => nil)
+        ems.floating_ips << FactoryGirl.create(
+          :floating_ip_azure,
+          :ext_management_system => ems.network_manager,
+          :network_port_id       => 1
+        )
+
+        FactoryGirl.create(:network_port_azure, :id => 2, :device_id => 1)
+        ems.floating_ips << FactoryGirl.create(
+          :floating_ip_azure,
+          :ext_management_system => ems.network_manager,
+          :network_port_id       => 2
+        )
+
+        ems.floating_ips << FactoryGirl.create(
+          :floating_ip_azure,
+          :ext_management_system => ems.network_manager,
+          :network_port_id       => nil
+        )
+      end
+
+      it "allowed_floating_ips" do
+        expect(workflow.allowed_floating_ip_addresses.length).to eq(2)
+      end
+    end
   end
 
   context "with applied tags" do