Return the available Floating IPs in Azure. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djberg96, @blomquisg - please review. |
bronaghs
commented
Jan 16, 2017
| @@ -1,2 +1,5 @@ | |||
| class ManageIQ::Providers::Azure::NetworkManager::FloatingIp < ::FloatingIp | |||
| def self.available | |||
| joins(:network_port).where({ "network_ports.device_id" => nil }) + where(:network_port_id => nil) | |||
| end | |||
There was a problem hiding this comment.
@djberg96 @blomquisg - expensive? I'm not sure how to optimize this given the associations that are in place.
bronaghs
force-pushed
the
floating_ip_available_method_change
branch
from
0e720a0
to
a353be5
Compare
bronaghs
force-pushed
the
floating_ip_available_method_change
branch
from
a353be5
to
659a8f8
Compare
|
Checked commit bronaghs@659a8f8 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 |
djberg96
reviewed
Jan 17, 2017
| @@ -1,2 +1,5 @@ | |||
| class ManageIQ::Providers::Azure::NetworkManager::FloatingIp < ::FloatingIp | |||
| def self.available | |||
There was a problem hiding this comment.
Should this be :available??
There was a problem hiding this comment.
@djberg96 - I had wondered the same thing, but no:
https://github.com/ManageIQ/manageiq/blob/master/app/models/floating_ip.rb
There was a problem hiding this comment.
@bronaghs ok, understood.
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #12300 changed the Floating::IP available method to return floating IPs not associated with either a VM or a NIC. The FloatingIp::available method is used in cloud instance provisioning to display a list of available floating IPs that can be re-used. This change inadvertently affected the Azure provider integration where a FloatingIp is considered available when it is associated with a NIC as long as that NIC is not attached to another device, which can occur when a VM is deleted and its NIC and IP remain orphaned.
This PR is for an Azure specific way to determine available Floating Ips.
https://bugzilla.redhat.com/show_bug.cgi?id=1380728