bin/setup - create manageiq/log manually

[cben]

Similar to ManageIQ/manageiq-ui-classic#4502, ManageIQ/manageiq-providers-nuage#130.

Since ManageIQ/manageiq#17663, there is no manageiq/log directory by default.
This breaks Travis e.g. https://travis-ci.org/ManageIQ/manageiq-providers-kubernetes/jobs/418623069

@miq-bot add-label bug, developer, test

@kbrock @himdel @miha-plesko please review

[miha-plesko]

LGTM. Would prefer native ruby solution like here ManageIQ/manageiq-providers-nuage#130 but it's up to you.

[cben]

Switched to native ruby, PTAL
Deviated from ManageIQ/manageiq-providers-nuage#130 — kept it outside the if, as I think if you manually create or symlink a fresh spec/manageiq with log/, bin/setup should create it.

[miq-bot]

Checked commits cben/manageiq-providers-kubernetes@a41d214~...01bc248 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

[miha-plesko]

Good point @cben I like your solution because it (a) uses absolute path and will work regardless where it's called from and (b) what you say with IF, we should perform the call always. Will copy this one from you, thanks.

[cben]

@kbrock @agrare can you merge (dont want to merge my own)

EDIT: hold on for gitter discussion to settle

[tadeboro]

I think that in case spec/manageiq is a symlink, bin/setup should not mess with developer managed content. When developer creates this symlink, he took the responsibility of keeping the things up and running.

[kbrock]

Thanks so much for your feedback @cben

I'm hoping this fix in one place will fix the problem

ManageIQ/manageiq#17886