remote log/.gitkeep #17663
Merged
remote log/.gitkeep #17663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
log_gitkeep
branch
2 times, most recently
from
4795d74
to
90a78de
Compare
bdunne
reviewed
Aug 20, 2018
.travis.yml
Outdated
| @@ -25,6 +25,7 @@ addons: | |||
| postgresql: '9.5' | |||
| before_install: | |||
| - source ${TRAVIS_BUILD_DIR}/tools/ci/before_install.sh | |||
| - mkdir ${TRAVIS_BUILD_DIR}/log | |||
There was a problem hiding this comment.
Should this be done before before_install.sh?
There was a problem hiding this comment.
this works, but I'll change - thnx
Our appliances link log to a different direction. This means it will always be a modified git tree. Git stash does not work across symbolic links. so it makes patching and git functions difficult on the appliance
|
... no need for @Fryguy to be assigned - but if you have an opinion Jason, please share |
|
Checked commit kbrock@ab4fa87 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Aug 20, 2018
|
oh no - looks like all repos will need some |
cben
added a commit
to cben/manageiq-providers-openshift
that referenced
this pull request
Aug 21, 2018
Since ManageIQ/manageiq#17663, there is no manageiq/log directory by default.
kbrock
added a commit
to kbrock/manageiq
that referenced
this pull request
Aug 21, 2018
in ab4fa87 we removed the creation of the log directory In production / appliances, we don't want an actual log directory. Unfortunatly the current solution caused issues for plugins Instead, the log creation was moved to the environment setup. So all plugins travis builds will get the benefit ManageIQ#17663
kbrock
added a commit
to kbrock/manageiq
that referenced
this pull request
Aug 21, 2018
in ab4fa87 we removed the creation of the log directory In production / appliances, we don't want an actual log directory. Unfortunatly the current solution caused issues for plugins Instead, the log creation was moved to the environment setup. So all plugins travis builds will get the benefit ManageIQ#17663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our appliances link log to a different direction.
This means it will always be a modified git tree.
Git stash does not work across symbolic links. so it makes patching and git
functions difficult on the appliance
Not sure the downside of not having a
logdirectory by default on a developer's rails machine.The only downside I can see.