Do not pass ids to child inventory collections #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not pass ids to child inventory collections, these are automatically populated by :parent_inventory_collections option. Passing them like this will fail with a new assert added to core.
|
@miq-bot add_label refactoring |
|
Checked commit Ladas@57c24f7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot assign @pkliczewski |
|
@pkliczewski the core PR looks good to me but I'll hold off merging it until you ACK this |
pkliczewski
approved these changes
May 14, 2018
|
@pkliczewski I merged the core PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not pass ids to child inventory collections, these are
automatically populated by :parent_inventory_collections option.
Passing them like this will fail with a new assert added to core in [https://github.com/ManageIQ/manageiq/pull/17408]