Targeted scope serialization #17408
Merged
Targeted scope serialization #17408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance ReferenceStorage so it's usable for TargetedScope
Turn targeted_scope into ReferenceStorage
Update usage of targeted_scope
Make targeted_scope serialization work
Fix typo in comment
Simplify to_hash serialization condition
Add guard for full reference building.
Make targeted_scope serialization non recursive for now
Test targeted_scope serialization works
1 task
Ladas
changed the title
Fryguy
reviewed
May 11, 2018
| @@ -74,7 +74,7 @@ def build_full_reference(data, keys) | |||
| if data.kind_of?(Hash) | |||
| data | |||
| else | |||
| # assert_index makes sure that only keys of size 1 can go here | |||
| raise "Please provide Hash as a reference, :manager_ref count includes more then 1 attribute. keys: #{keys}, data: #{data}" if keys.size > 1 | |||
|
Checked commits Ladas/manageiq@fc2b8e8~...a0e65d1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
May 14, 2018
There was a problem hiding this comment.
LGTM, pending approval of ManageIQ/manageiq-providers-kubevirt#68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeling targeted_scope as ReferenceStorage and making it serializable.
After merging this, we need to merge these to fix failing CI:
ManageIQ/manageiq-providers-kubevirt#68
ManageIQ/manageiq-providers-vmware#258