Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider base class handles the managers' destroy now #198

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Provider base class handles the managers' destroy now #198

merged 1 commit into from
Jan 22, 2018

Conversation

jameswnl
Copy link

No description provided.

@miq-bot miq-bot added the wip label Jan 17, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2018

Checked commit jameswnl@49c59f8 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@mansam
Copy link
Contributor

mansam commented Jan 18, 2018

@jameswnl is there more to be done on this since it's marked WIP? I'm assuming the reason the rest of the PRs have failing tests is because something on core changed and this hasn't been merged yet.

@mansam mansam mentioned this pull request Jan 18, 2018
Merged
@jameswnl
Copy link
Author

@mansam this should be the only change needed, to sync up with ManageIQ/manageiq#16755 which makes the Provider.destroy handling destroy of contained managers.

I've checked with UI team when user is destroying an Openstack provider, UI invokes the ManageIQ::Providers::CloudManager.destroy_queue, not the provider object. Do you know when will this provider record got removed?

@mansam
Copy link
Contributor

mansam commented Jan 19, 2018

@jameswnl I'm sorry, I don't think I quite understand the question. destroy_queue puts a message on the queue to asynchronously call destroy on the provider. That message should be received and acted on quickly.

@mansam
Copy link
Contributor

mansam commented Jan 22, 2018

@jameswnl If this is ready to be merged, could you remove the [WIP]?

@jameswnl
Copy link
Author

@miq-bot remove_labels wip

@jameswnl jameswnl changed the title [WIP] Provider base class handles the managers' destroy now Provider base class handles the managers' destroy now Jan 22, 2018
@miq-bot miq-bot removed the wip label Jan 22, 2018
@mansam mansam merged commit f34d224 into ManageIQ:master Jan 22, 2018
aufi added a commit to aufi/manageiq-providers-openstack that referenced this pull request Jan 23, 2018
@aufi
Fix Infra provider deletion
831a7af 
Change introduced in ManageIQ/manageiq#16755 is not
compatible with OSP provider which uses cascade deletion of related providers.

Nullification introduced in ManageIQ#198
breaks tests and possibly affects Infra provider deletion.

Trying override destroy method with original from AR until we get better solution (preferably in main repo).
@aufi aufi mentioned this pull request Jan 23, 2018
Closed
@aufi aufi added the bug label Jan 30, 2018
@aufi aufi added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jameswnl @miq-bot @mansam @aufi @mimodian