[WIP] Fix destroy provider #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hostname validation was added to newest version, updating gemspec to include it.
Change introduced in ManageIQ/manageiq#16755 is not compatible with OSP provider which uses cascade deletion of related providers. Nullification introduced in ManageIQ#198 breaks tests and possibly affects Infra provider deletion. Trying override destroy method with original from AR until we get better solution (preferably in main repo).
|
@Ladas First attempt.. |
|
Checked commits aufi/manageiq-providers-openstack@df8ced4~...831a7af with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
requested changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change introduced in ManageIQ/manageiq#16755 is not
compatible with OSP provider which uses cascade deletion of related providers.
Nullification introduced in #198
breaks tests and possibly affects Infra provider deletion.
Trying override destroy method with original from AR until we get better solution (preferably in main repo).