Support Cinder's volume-extend action #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on ManageIQ/manageiq#18560 |
mansam
force-pushed
the
support-volume-resizing
branch
from
ce07f5b
to
c2bc078
Compare
mansam
changed the title
|
Looks good to me, Sam 👍 |
|
This pull request is not mergeable. Please rebase and repush. |
mansam
force-pushed
the
support-volume-resizing
branch
from
c2bc078
to
37b662e
Compare
|
Checked commit mansam@37b662e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an RFE for supporting Cinder's volume extend action. I don't know if it'll be accepted, but I had time so why not be proactive about it. https://bugzilla.redhat.com/show_bug.cgi?id=1685063
Volume extension has to be done via a separate request from updating other fields. I've added it as part of
raw_update_volumesince the alternative would be having to add a new UI just for this purpose. The way this is set up, if updating the volume's attributes fail, the whole thing will fail. But if only extending fails, the rest of the update will succeed but you'll still get a message in the UI about the resize having failed. If that seems odd, we could probably set up unique notifications and exceptions for volume-extend so that you get a notification for the attribute update and a separate notification for the results of the extend.@aufi, what do you think about that?