Add Volume Resizing capability to SupportsFeatureMixin #18560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2019
|
Checked commit mansam@c3e0468 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
added a commit
that referenced
this pull request
Mar 15, 2019
Add Volume Resizing capability to SupportsFeatureMixin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Openstack and Amazon providers both theoretically support resizing volumes, but currently detection of this feature is done in the UI via a conditional on the class name of the provider. Adding this as a capability to SupportsFeatureMixin and as a virtual column on ExtManagementSystem would allow this to be handled in a cleaner way in the UI.
See also ManageIQ/manageiq-providers-openstack#448