Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the DDF fields more similar to the current form's layout + i18n #557

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

skateman
Copy link
Member

@skateman skateman commented Feb 10, 2020

Updating the initial DDF schema to look more similar to the current form's layout. Here are the catches:

  • Keystone v2 as default API version - suggested by @aufi
  • Events type selection changed from radio to select because DDF doesn't do inline radios
  • SSL enforcement dropdown doesn't allow to select an option - reported here
  • No AMQP fallback hostnames - will be added after this bug gets fixed
  • Made API port for AMQP a required field
  • RSA Private Key field is set to password as DDF doesn't do file uploads yet

Old Default Endpoint:
Screenshot from 2020-02-12 10-07-43
Old AMQP Endpoint:
Screenshot from 2020-02-12 10-07-32
Old RSA Endpoint:
Screenshot from 2020-02-12 10-07-54

New Default Endpoint:
Screenshot from 2020-02-12 10-30-36

New AMQP Endpoint:
Screenshot from 2020-02-12 10-31-00

New RSA Endpoint:
Screenshot from 2020-02-12 10-32-27

ManageIQ/manageiq#18818

The verify_credentials has been also updated in order to support validation for AMQP.

@miq-bot miq-bot added the wip label Feb 10, 2020
@skateman skateman force-pushed the unify-ddf-fields branch 2 times, most recently from 5db26c0 to 467de00 Compare February 12, 2020 08:58
@skateman skateman changed the title [WIP] Make the DDF fields more similar to the current form's layout + i18n Make the DDF fields more similar to the current form's layout + i18n Feb 12, 2020
@miq-bot miq-bot removed the wip label Feb 12, 2020
@miq-bot
Copy link
Member

miq-bot commented Feb 12, 2020

Checked commits skateman/manageiq-providers-openstack@9939df0~...8bf6014 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@aufi
Copy link
Member

aufi commented Feb 13, 2020

Looks good to me 👍

The "No AMQP fallback hostnames" doesn't seem to be an issue of OpenStack provider. The provider backend code counts with these attributes, but current UI doesn't fill it into database.

@aufi
Copy link
Member

aufi commented Feb 14, 2020

@skateman I checked out this locally I cannot see the change showed on attached screenshots. Is there any other dependent PR?

@skateman
Copy link
Member Author

@aufi yeah, there's a WIP PR, you will need to rebase and run bin/update, however, it only implements validation for now, not saving.

@skateman
Copy link
Member Author

Can we get this in please? I would like to work on this further.

@agrare agrare self-assigned this Feb 25, 2020
@agrare agrare merged commit 8088ddc into ManageIQ:master Feb 25, 2020
@skateman skateman deleted the unify-ddf-fields branch February 25, 2020 15:28
@agrare agrare added this to the Sprint 131 Ending Mar 2, 2020 milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants