Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the AsyncCredentials component #6656

Closed
skateman opened this issue Feb 5, 2020 · 6 comments
Closed

Issues with the AsyncCredentials component #6656

skateman opened this issue Feb 5, 2020 · 6 comments
Assignees

Comments

@skateman
Copy link
Member

skateman commented Feb 5, 2020

Right now the AsyncCredentials component marks itself invalid if at least one of its fields gets changed after a validation. However, if you change a field from validationDependencies, the form still shows as valid.

Parent issue: ManageIQ/manageiq#18818

@miq-bot add_label bug
@miq-bot assign @Hyperkid123

@skateman
Copy link
Member Author

skateman commented Feb 7, 2020

The submit button is also enabled after re-pressing the Validate button upon a successful validation:
Screenshot from 2020-02-07 12-46-01

@skateman skateman changed the title AsyncCredentials component should mark itself invalid if validationDependencies changes Issues with the AsyncCredentials component Feb 7, 2020
@skateman
Copy link
Member Author

skateman commented Feb 7, 2020

When submitting the form, the component also submits itself as valid. It is kinda obvious as you cannot submit stuff with invalid credentials, so I think that shouldn't happen at all. However, I would understand if you want to keep this behavior. In such case, would be a way to not have this "feature" in my specialized component?

Edit: nevermind, I am just removing the value(s) upon submit

@skateman
Copy link
Member Author

skateman commented Feb 11, 2020

The asyncValidate function gets two arguments, the first is the full form state and the second is the list of the field names under the component. This seems a little redundant to me, however, the validationDependencies never get into the second argument, which is I guess a bug.

Resolved in #6673

@skateman
Copy link
Member Author

A select-field in under the component doesn't allow me to select any option.

@Hyperkid123
Copy link
Contributor

A select-field in under the component doesn't allow me to select any option.

I suspect the enhanced onChange is going to be a problem. Maybe it is not passed down properly.

@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2020

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants