Introduce a DDF component for provider credentials validation #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
skateman
force-pushed
the
validate-provider-component
branch
2 times, most recently
from
e0a8991
to
8256369
Compare
skateman
changed the title
|
@miq-bot add_label enhancement, react |
skateman
force-pushed
the
validate-provider-component
branch
from
8256369
to
3a1d478
Compare
|
Checked commit skateman@3a1d478 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Hyperkid123
approved these changes
Feb 10, 2020
|
@miq-bot assign @mzazrivec |
|
I have no problem merging this, though I'd probably rather also wait for @himdel's opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component is a wrapper around
AsyncCredentialswith a pre-set validation function that in the future will validate the credentials using the API.Parent issue: ManageIQ/manageiq#18818
Related bug: #6656