Reconnect host on provider add #189

pkliczewski · 2018-01-05T13:07:45Z

We need to make sure that when we remove a provider and add it again we
will keep using the same host entities. Without this change add and remove
provider cause to duplicate hosts.

Fixes https://bugzilla.redhat.com/1528859

pkliczewski · 2018-01-05T13:08:44Z

Bug 1528859 - [RHV][Graph Refresh] "Archived" Hosts are displayed several times on CFME, with Power state: ON ("Running")

miq-bot · 2018-01-05T13:10:16Z

@pkliczewski 'Ladas agrare' is an invalid assignee, ignoring...

pkliczewski · 2018-01-05T13:10:51Z

@miq-bot assign @Ladas

pkliczewski · 2018-01-05T13:11:04Z

@agrare please review

pkliczewski · 2018-01-05T13:11:46Z

@miq-bot add_label gaprindashvili/yes

Ladas · 2018-01-05T13:37:29Z

app/models/manageiq/providers/redhat/inventory_collection_default/infra_manager.rb

@@ -76,6 +76,39 @@ def root_folders(extra_attributes = {})
      attributes.merge!(extra_attributes)
    end

+    def hosts(extra_attributes = {})
+      reconnect_block = lambda do |inventory_collection, inventory_objects_index, attributes_index|


we can use the same code for Vms, so we are compatible with old refresh, @agrare what else do we reconnect?

Great idea, just hosts and vms currently.

Ladas

Lets apply this also to Vms and add specs please :-)

agrare · 2018-01-05T13:47:03Z

@Ladas @pkliczewski this probably belongs in the main ManagerRefresh::InventoryCollectionDefault::InfraManager since it isn't specific to ovirt

pkliczewski · 2018-01-05T13:48:55Z

@agrare will move it to the main repo.

Ladas · 2018-01-05T14:37:04Z

@agrare right, so @pkliczewski is adding it here because e.g. VmWare reconnect is different. In here we will reconnect using only ems_ref.

agrare · 2018-01-05T14:49:17Z

@Ladas you mean for hosts? That is different behavior between normal and graph refresh then.

Ladas · 2018-01-05T14:51:20Z

@agrare right @pkliczewski says they need just reconnecting by :ems_ref, because they don't have the scenario of loosing the whole RHEV DB, that would lead to new ems_refs , like VmWare

agrare · 2018-01-05T14:56:16Z

@Ladas that's not the only reason we lookup by hostname, if you drop a host from a provider and connect it to another this would also pick that up.

pkliczewski · 2018-01-05T15:09:26Z

This PR requires ManageIQ/manageiq#16750

Ladas · 2018-01-08T12:40:11Z

spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_4_async_graph_spec.rb

+    EmsRefresh.refresh(@ems)
+    @ems.reload
+
+    vm = VmOrTemplate.find_by(:uid_ems => "3a9401a0-bf3d-4496-8acf-edd3e903511f")


probably also assert that

expect(VmOrTemplate.where(:uid_ems => "3a9401a0-bf3d-4496-8acf-edd3e903511f").count).to eq 1

To make sure the Vm is not duplicated ,same for the Host

Done, @Ladas are you ok with the specs now?

yes, awesome

We need to make sure that when we remove a provider and add it again we will keep using the same host entities. Without this change add and remove provider cause to duplicate hosts. Fixes https://bugzilla.redhat.com/1528859

miq-bot · 2018-01-09T15:03:28Z

Checked commit pkliczewski@90fcaed with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

Ladas

Looks great now 👍

pkliczewski · 2018-01-09T16:10:24Z

@masayag @oourfali please review

Reconnect host on provider add (cherry picked from commit 057e7d0) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532332

simaishi · 2018-01-10T19:12:20Z

Gaprindashvili backport details:

$ git log -1
commit bc5bd40f2d640fa8a62154f05bd8035c88c2c7e1
Author: Moti Asayag <masayag@redhat.com>
Date:   Wed Jan 10 10:32:48 2018 +0200

    Merge pull request #189 from pkliczewski/reconnect
    
    Reconnect host on provider add
    (cherry picked from commit 057e7d051f62256e488dea83ab004714880755aa)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532332

miq-bot assigned Ladas Jan 5, 2018

miq-bot added the gaprindashvili/yes label Jan 5, 2018

Ladas reviewed Jan 5, 2018

View reviewed changes

Ladas suggested changes Jan 5, 2018

View reviewed changes

chessbyte added blocker bug labels Jan 5, 2018

pkliczewski force-pushed the reconnect branch from 4a60ce7 to fe4566d Compare January 5, 2018 15:07

pkliczewski mentioned this pull request Jan 5, 2018

Reconnect host on provider add ManageIQ/manageiq#16750

Merged

Ladas reviewed Jan 8, 2018

View reviewed changes

pkliczewski force-pushed the reconnect branch from fe4566d to cd71435 Compare January 8, 2018 12:55

pkliczewski closed this Jan 8, 2018

pkliczewski reopened this Jan 8, 2018

pkliczewski closed this Jan 9, 2018

pkliczewski reopened this Jan 9, 2018

Reconnect host on provider add

90fcaed

We need to make sure that when we remove a provider and add it again we will keep using the same host entities. Without this change add and remove provider cause to duplicate hosts. Fixes https://bugzilla.redhat.com/1528859

pkliczewski force-pushed the reconnect branch from cd71435 to 90fcaed Compare January 9, 2018 14:59

Ladas approved these changes Jan 9, 2018

View reviewed changes

masayag approved these changes Jan 10, 2018

View reviewed changes

masayag merged commit 057e7d0 into ManageIQ:master Jan 10, 2018

simaishi pushed a commit that referenced this pull request Jan 10, 2018

Merge pull request #189 from pkliczewski/reconnect

bc5bd40

Reconnect host on provider add (cherry picked from commit 057e7d0) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532332

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Jan 10, 2018

agrare added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reconnect host on provider add #189

Reconnect host on provider add #189

pkliczewski commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

miq-bot commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

Ladas Jan 5, 2018

agrare Jan 5, 2018

Ladas left a comment

agrare commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

Ladas commented Jan 5, 2018 •

edited

Loading

agrare commented Jan 5, 2018

Ladas commented Jan 5, 2018

agrare commented Jan 5, 2018

pkliczewski commented Jan 5, 2018 •

edited

Loading

Ladas Jan 8, 2018

pkliczewski Jan 8, 2018

pkliczewski Jan 9, 2018

Ladas Jan 9, 2018

miq-bot commented Jan 9, 2018

Ladas left a comment

pkliczewski commented Jan 9, 2018

simaishi commented Jan 10, 2018

Reconnect host on provider add #189

Reconnect host on provider add #189

Conversation

pkliczewski commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

miq-bot commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

Ladas Jan 5, 2018

Choose a reason for hiding this comment

agrare Jan 5, 2018

Choose a reason for hiding this comment

Ladas left a comment

Choose a reason for hiding this comment

agrare commented Jan 5, 2018

pkliczewski commented Jan 5, 2018

Ladas commented Jan 5, 2018 • edited Loading

agrare commented Jan 5, 2018

Ladas commented Jan 5, 2018

agrare commented Jan 5, 2018

pkliczewski commented Jan 5, 2018 • edited Loading

Ladas Jan 8, 2018

Choose a reason for hiding this comment

pkliczewski Jan 8, 2018

Choose a reason for hiding this comment

pkliczewski Jan 9, 2018

Choose a reason for hiding this comment

Ladas Jan 9, 2018

Choose a reason for hiding this comment

miq-bot commented Jan 9, 2018

Ladas left a comment

Choose a reason for hiding this comment

pkliczewski commented Jan 9, 2018

simaishi commented Jan 10, 2018

Ladas commented Jan 5, 2018 •

edited

Loading

pkliczewski commented Jan 5, 2018 •

edited

Loading