Reconnect host on provider add #16750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specs available here ManageIQ/manageiq-providers-ovirt#189 |
|
@miq-bot add_label gaprindashvili/yes |
Ladas
reviewed
Jan 5, 2018
| } | ||
|
|
||
| attributes.merge!(extra_attributes) | ||
| end | ||
|
|
||
| def vms(extra_attributes = {}) |
There was a problem hiding this comment.
There was a problem hiding this comment.
@Ladas I did that but the specs started to fail for CloudManager so rolling back and keeping it on InfraManager level.
There was a problem hiding this comment.
ok, I will looks into that, let's start with infra then
We need to make sure that when we remove a provider and add it again we will keep using the same host entities. Without this change add and remove provider cause to duplicate hosts. Fixes https://bugzilla.redhat.com/1528859
|
Checked commit pkliczewski@2ede836 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@Ladas please review |
|
@agrare Are you OK with this PR? |
agrare
approved these changes
Jan 8, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 8, 2018
Reconnect host on provider add (cherry picked from commit 1caf713) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532332
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that when we remove a provider and add it again we
will keep using the same host entities. Without this change add and remove
provider cause to duplicate hosts.
Fixes https://bugzilla.redhat.com/1528859