Parse the serial number during refresh #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@durandom who should I ask to review this? |
|
Do we need to update any specs for this change? Where is corresponding change for graph refresh? |
|
@pkliczewski you are right need to change graph refresh as well, can you point me to the place exactly? |
|
@borod108 afaik the schema pr is already merged, so nobody from the core needs to review this. Any corresponding PR for the UI or API? |
borod108
force-pushed
the
report_serial_number
branch
from
1b18d7e
to
4f38002
Compare
|
@pkliczewski done the changes, can you review again please? |
|
@pkliczewski can you please review? I added the fixes you requested. |
pkliczewski
approved these changes
Oct 6, 2017
bdunne
reviewed
Oct 13, 2017
| @@ -478,6 +478,7 @@ def hardwares_attributes | |||
| :manufacturer, | |||
| :memory_mb, | |||
| :model, | |||
| :serial_number, | |||
Parse the serial number of host during refresh. This is required for: https://bugzilla.redhat.com/show_bug.cgi?id=1410183
borod108
force-pushed
the
report_serial_number
branch
from
4f38002
to
dd6bab8
Compare
|
Checked commit borod108@dd6bab8 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the serial number of host during refresh.
This is required for:
https://bugzilla.redhat.com/show_bug.cgi?id=1410183
Required for:
ManageIQ/manageiq#15992