-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse the serial number during refresh #15992
Conversation
@masayag @pkliczewski @jhernand can someone please review? |
Is it RHV specific report? I do not see any information about it. If not how it would behave if the information is not there? |
This pull request is not mergeable. Please rebase and repush. |
@borod108 can you add a screenshot of what this looks like when it is populated and to @pkliczewski's point can you test what happens when it is not populated (i.e. currently every other infra provider) |
@agrare hi, I will add a screen shot, for others it will just show an empty column, not great :( |
@borod108 I think its fine as an empty column, the UI throws exceptions for missing fields sometimes that's all I wanted to check for :) |
Parse the serial number of host during refresh. This is required for: https://bugzilla.redhat.com/show_bug.cgi?id=1410183
0799376
to
848df70
Compare
Checked commit borod108@848df70 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 will merge when dependent PR is merged
Parse the serial number of host during refresh.
This is required for:
https://bugzilla.redhat.com/show_bug.cgi?id=1410183
This is dependent on:
ManageIQ/manageiq-providers-ovirt#97