Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use utility function vm_powered_on? instead manual comparison #204

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Use utility function vm_powered_on? instead manual comparison #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/manageiq/providers/vmware/cloud_manager/vm/operations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module ManageIQ::Providers::Vmware::CloudManager::Vm::Operations

included do
supports :terminate do
unsupported_reason_add(:terminate, "The VM is powered on") unless current_state == "off"
unsupported_reason_add(:terminate, "The VM is powered on") if vm_powered_on?
end
end

Expand Down
5 changes: 5 additions & 0 deletions spec/models/manageiq/providers/vmware/cloud_manager/vm_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@
let(:state) { :standby_guest }
include_examples "Vm operation is not available"
end

context("with :terminate") do
let(:state) { :terminate }
include_examples "Vm operation is available when not powered on"
end
end

context "when destroyed" do
Expand Down