-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CPU/MEM/HDD reconfiguration #231
Conversation
030a8cb
to
5fc1038
Compare
This pull request is not mergeable. Please rebase and repush. |
5fc1038
to
b29d82e
Compare
b29d82e
to
2d00be8
Compare
4e875de
to
47e6b79
Compare
With this commit we implement whatever support for virtual hardware reconfiguration. Namely, we support following operations for VM: - increase/decrease memory - increase/decrease number of cpu cores and sockets - increase disk size - add/remove disk BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1572086 Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
47e6b79
to
69b682f
Compare
Checked commit miha-plesko@69b682f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@agrare green. Was struggling with factorygirl-created snapshots where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Support CPU/MEM/HDD reconfiguration
Support CPU/MEM/HDD reconfiguration (cherry picked from commit 3991608) https://bugzilla.redhat.com/show_bug.cgi?id=1584699
Gaprindashvili backport details:
|
Fix list_storages build failure.
With this commit we implement support for virtual hardware reconfiguration. Namely, we support following operations for VM:
We also update refresh parser to fetch correct data for disks.
Video: http://x.k00.fr/reconfigure
Depends on: #261
Followup PR: ManageIQ/manageiq-ui-classic#3854
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1572086
@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @agrare