Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CPU/MEM/HDD reconfiguration #231

Merged
merged 1 commit into from
May 21, 2018

Conversation

miha-plesko
Copy link
Contributor

@miha-plesko miha-plesko commented Apr 20, 2018

With this commit we implement support for virtual hardware reconfiguration. Namely, we support following operations for VM:

  • increase/decrease memory
  • increase/decrease number of cpu cores and sockets
  • increase disk size
  • add/remove disk

We also update refresh parser to fetch correct data for disks.

Video: http://x.k00.fr/reconfigure
Depends on: #261
Followup PR: ManageIQ/manageiq-ui-classic#3854
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1572086

@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @agrare

@miq-bot miq-bot added the wip label Apr 20, 2018
@miha-plesko miha-plesko changed the title [WIP] Support CPU/MEM/HDD reconfiguration Support CPU/MEM/HDD reconfiguration Apr 26, 2018
@miq-bot miq-bot removed the wip label Apr 26, 2018
@miq-bot
Copy link
Member

miq-bot commented Apr 26, 2018

This pull request is not mergeable. Please rebase and repush.

@miha-plesko miha-plesko changed the title Support CPU/MEM/HDD reconfiguration [WIP] Support CPU/MEM/HDD reconfiguration May 15, 2018
@miq-bot miq-bot added wip and removed unmergeable labels May 15, 2018
@miha-plesko miha-plesko changed the title [WIP] Support CPU/MEM/HDD reconfiguration Support CPU/MEM/HDD reconfiguration May 16, 2018
@miq-bot miq-bot removed the wip label May 16, 2018
@miha-plesko
Copy link
Contributor Author

Hi @agrare, just updated this PR and I think it's ready for review. When #261 and this one are merged, we'll be able to work on the UI PR. I kindly ask for review.

@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @agrare

With this commit we implement whatever support for virtual hardware
reconfiguration. Namely, we support following operations for VM:

- increase/decrease memory
- increase/decrease number of cpu cores and sockets
- increase disk size
- add/remove disk

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1572086

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
@miq-bot
Copy link
Member

miq-bot commented May 18, 2018

Checked commit miha-plesko@69b682f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. 🍪

@miha-plesko
Copy link
Contributor Author

@agrare green. Was struggling with factorygirl-created snapshots where after :create callback on snapshot model causes some problems. Anyway, is fixed now.

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@agrare agrare merged commit 69b682f into ManageIQ:master May 21, 2018
agrare added a commit that referenced this pull request May 21, 2018
@agrare agrare added this to the Sprint 86 Ending May 21, 2018 milestone May 21, 2018
simaishi pushed a commit that referenced this pull request Jun 1, 2018
@simaishi
Copy link
Contributor

simaishi commented Jun 1, 2018

Gaprindashvili backport details:

$ git log -1
commit 6629a0ea0a63332970d8e41be7d3147d902e5056
Author: Adam Grare <agrare@redhat.com>
Date:   Mon May 21 08:19:30 2018 -0400

    Merge pull request #231 from miha-plesko/hardware-reconfigure
    
    Support CPU/MEM/HDD reconfiguration
    (cherry picked from commit 39916084216297215024b2b24c56ad441433914b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1584699

@miha-plesko miha-plesko deleted the hardware-reconfigure branch January 7, 2019 08:25
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants