Resize disk reconfigure screen #16711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2017 15:55
…ureScreen * origin/master: (45 commits) Order queue messages by ID for ems spec test Parse models of > 3 namespaces Make ContainerLogger respond to #instrument Call request_owner_email method to handle getting email for Services and VM provisions. Removed to_s from get_option(:owner_email) to cause an error if email is nil. Remove commented tests Added "Mass Transform" feature Return only CloudVolume types which really exists in DB Mark task as active while destroying an ems Extract queue message delivery into helper method Create a task when destroying an ems Stop cashing @column_cache and @model_relats for ChargebackVm Remove Dictionary.gettext() with static string argument Remove ui_lookup() with static string argument Use UUID to ensure the uniqueness of job template name Procfile.example - add workers needed for embedded ansible Calculate Metering Used Hours only from used hours add :container_quota_scope factory Change worker validation to check USS not PSS Show USS instead of PSS in rake evm:status Also log the server/worker unique set size (USS) ...
|
Checked commits evertmulder/manageiq@7220cc2~...e72185c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
reviewed
Jan 10, 2018
| @@ -32,6 +32,7 @@ def self.get_description(req_obj) | |||
| new_settings << "Total Processors: #{req_obj.options[:number_of_cpus].to_i}" unless req_obj.options[:number_of_cpus].blank? | |||
| new_settings << "Add Disks: #{req_obj.options[:disk_add].length}" unless req_obj.options[:disk_add].blank? | |||
| new_settings << "Remove Disks: #{req_obj.options[:disk_remove].length}" unless req_obj.options[:disk_remove].blank? | |||
| new_settings << "Resize Disks: #{req_obj.options[:disk_resize].length}" unless req_obj.options[:disk_resize].blank? | |||
There was a problem hiding this comment.
@tinaafitz This will require quota changes to fully support. We should open RFE to track.
|
Hi @gmcculloug, there is a PR that depends on this one and we need to backport it to GA branch: ManageIQ/manageiq-providers-vmware#231 Is it safe to backport this one as well/are there any related PRs? /cc @simaishi |
|
Yes, this is safe to backport. This PR is referenced from ManageIQ/manageiq-providers-vmware#164 so that is likely required as well. |
|
.. and as per ManageIQ/manageiq-ui-classic#3127, I think we also need ManageIQ/manageiq-ui-classic#3128 |
simaishi
pushed a commit
that referenced
this pull request
Jun 1, 2018
Resize disk reconfigure screen (cherry picked from commit 9134e2a)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On of the PRs to support resize disks from the reconfigure screen:
See: ManageIQ/manageiq-ui-classic#3127