Resize disk reconfigure screen #3128

evertmulder · 2017-12-21T12:24:51Z

Compute > Infra > VMs, select a vm, toolbar Configuration > Reconfigure selected items

PR to support resize disk from reconfigure screen.

See: #3127

Closes #3127

martinpovolny · 2017-12-23T15:31:30Z

Restarted travis.

gmcculloug · 2018-01-10T19:54:50Z

@dclarizio See screenshot in PR #3127. Please assign these two PRs.

dclarizio · 2018-01-10T21:58:05Z

@evertmulder I'm not seeing any tests, perhaps @AparnaKarve or @himdel can recommend some.

AparnaKarve · 2018-01-10T22:34:28Z

@evertmulder Can you add some screenshots related to this feature?

himdel · 2018-01-11T13:14:23Z

(pending core because ManageIQ/manageiq-providers-vmware#164)

himdel · 2018-01-11T13:16:35Z

@evertmulder You'll need to rebase - no merge commits in a PR please ;)

(This should also fix the ruby specs.)

JS specs failure looks related

himdel · 2018-01-11T13:18:20Z

app/assets/javascripts/controllers/reconfigure/reconfigure_form_controller.js

+ vm.setEnableAddDiskButton = function () {
+ var nrDisksAfterReconfigure=0;
+ angular.forEach(vm.reconfigureModel.vmdisks, function(disk){
+ switch (disk.add_remove) {


Wrong indentation ;)

Please see the rest of the code climate warnings - feel free to ignore "Function updateDisksAddRemove has 36 lines of code (exceeds 25 allowed). Consider refactoring." but the rest is definitely relevant :).

himdel · 2018-01-11T13:22:10Z

app/views/vm_common/_reconfigure.html.haml

+ "placeholder" => "Enter Size",
+ "ng-change" => "vm.hdChanged()",
+ "validate-multiple" => "1",
+ :miqmin => "{{ (disk.orgHdUnit=='GB') && (1024*disk.orgHdSize+1) || (1*disk.orgHdSize+1)}}",


CC won't warn here, but please keep the same rules...

:miqmin => "{{ (disk.orgHdUnit === 'GB') && (1024 * disk.orgHdSize + 1) || (1 * disk.orgHdSize + 1) }}",

EDIT: also, consider using ?: instead of && || unless you're really trying to convey the equivalent of
(disk.orgHdUnit === 'GB') ? ((1024 * disk.orgHdSize + 1) || (1 * disk.orgHdSize + 1)) : (1 * disk.orgHdSize + 1)

@himdel Sorry, over looked this one. Should be fix now.

himdel · 2018-01-11T13:28:10Z

As for tests, I'm not sure what to suggest, sorry - can't really tell the refactoring bits from the actual changes (this being one big commit).

@evertmulder Care to elaborate what this actually changes please? :) (The screenshot might also help.)

evertmulder · 2018-01-11T21:32:14Z

@himdel Thanks for all the reviews. Tomorrow I will make some time addressing the comments. Sorry for the late response, the comments are not going to my corporate mail, so I just saw them.

@AparnaKarve Added screenshots

evertmulder · 2018-01-12T15:42:18Z

I am afraid I did merge instead of rebase. Can I do something to fix this?

AparnaKarve · 2018-01-12T15:52:59Z

Try removing those 2 merge commits 93bfb65 and ff0f048 and then a rebase

evertmulder · 2018-01-15T10:47:03Z

removed the merge commits. Currently working on the provider for this PR.

agrare · 2018-01-18T17:50:32Z

ManageIQ/manageiq-providers-vmware#164 has been merged

agrare · 2018-01-18T18:52:48Z

@miq-bot remove-label pending core

martinpovolny · 2018-01-19T09:13:12Z

Can you, please, address the @miq-bot issue?

agrare

👍 confirmed this PR worked while testing ManageIQ/manageiq-providers-vmware#164

himdel · 2018-01-24T13:03:13Z

JS failures still relevant,

also, please run eslint manually on your new code, seems like CC is not reporting properly... I'm seeing at least these in a few places..

  error    Expected indentation of 2 spaces but found 4  indent
  error    Expected space(s) after "if"                  keyword-spacing
  warning  Expected { after 'if' condition               curly
  warning  Expected { after 'else'                       curly

@miq-bot add_label wip

evertmulder · 2018-01-24T21:48:24Z

@himdel Fixed all eslint issues I could find in the file. Fixed 127 issues.
I will take a look a the jasmin issues also. Fixed the jasmin issues.
It seems all PRs fail with the JS testsuite:

submitButtonClicked when the API call fails clears flash messages

for ruby 2.4.2

I keep getting Redux errors running the test suite (like Redux API ManageIQ.redux namespace should be defined), but travis does not.

himdel · 2018-01-30T15:50:55Z

It seems all PRs fail with the JS testsuite

@evertmulder Sorry about that , should be fixed now, restarting travis.

That said, can you also look at #3128 (review) please? :)

miq-bot · 2018-01-31T20:38:09Z

Checked commit evertmulder@ffa6ad5 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 1 offense detected

**

💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.5-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

evertmulder · 2018-02-09T20:43:04Z

@himdel Is there anything I can improve? I think I fixed all review comments ...

himdel · 2018-02-12T13:34:05Z

@evertmulder Sorry about the delay, there was a spec failure but it was on our side..
Restarted, looking again.

himdel · 2018-02-14T13:35:15Z

LGTM, tested in the UI 👍

simaishi · 2018-06-01T14:30:05Z

@himdel can this be gaprindashvili/yes? We need reconfigure disk feature in G-branch (ManageIQ/manageiq#16711 (comment))

himdel · 2018-06-01T14:34:25Z

@simaishi Assuming ManageIQ/manageiq-providers-vmware#164 can be, I think there is no problem here.

Resize disk reconfigure screen (cherry picked from commit 8835899)

simaishi · 2018-06-01T14:58:01Z

Gaprindashvili backport details:

$ git log -1
commit c1d8f212ec734e1dc4f9ede5358d12b7128f3274
Author: Martin Hradil <himdel@seznam.cz>
Date:   Wed Feb 14 13:35:18 2018 +0000

    Merge pull request #3128 from evertmulder/ResizeDisk_ReconfigureScreen
    
    Resize disk reconfigure screen
    (cherry picked from commit 8835899188969665caca9894400db51c48dbd645)

simaishi · 2018-06-01T14:58:25Z

Thanks Martin, backported VMware PR as well.

evertmulder mentioned this pull request Dec 21, 2017

Reconfigure VM: Option to resize disk (see linked prs) #3127

Closed

mzazrivec added compute/infrastructure pending core enhancement labels Dec 22, 2017

dclarizio assigned himdel Jan 10, 2018

dclarizio requested a review from AparnaKarve January 10, 2018 21:57

himdel reviewed Jan 11, 2018

View reviewed changes

evertmulder requested a review from martinpovolny as a code owner January 15, 2018 10:30

miq-bot removed the pending core label Jan 18, 2018

martinpovolny approved these changes Jan 19, 2018

View reviewed changes

agrare approved these changes Jan 19, 2018

View reviewed changes

miq-bot changed the title ~~Resize disk reconfigure screen~~ [WIP] Resize disk reconfigure screen Jan 24, 2018

miq-bot added the wip label Jan 24, 2018

evertmulder changed the title ~~[WIP] Resize disk reconfigure screen~~ Resize disk reconfigure screen Jan 27, 2018

miq-bot removed the wip label Jan 27, 2018

himdel closed this Jan 30, 2018

himdel reopened this Jan 30, 2018

Add resize support to reconfigure screen

ffa6ad5

himdel closed this Feb 8, 2018

himdel reopened this Feb 8, 2018

himdel added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 14, 2018

himdel merged commit 8835899 into ManageIQ:master Feb 14, 2018

simaishi mentioned this pull request Jun 1, 2018

Resize disk reconfigure screen ManageIQ/manageiq#16711

Merged

simaishi pushed a commit that referenced this pull request Jun 1, 2018

Merge pull request #3128 from evertmulder/ResizeDisk_ReconfigureScreen

c1d8f21

Resize disk reconfigure screen (cherry picked from commit 8835899)

simaishi added blocker gaprindashvili/backported labels Jun 1, 2018

dayleparker mentioned this pull request Aug 1, 2018

Bz#1578239 reconfigure resize to gaprindashvili ManageIQ/manageiq-documentation#919

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resize disk reconfigure screen #3128

Resize disk reconfigure screen #3128

evertmulder commented Dec 21, 2017 •

edited by himdel

Loading

martinpovolny commented Dec 23, 2017

gmcculloug commented Jan 10, 2018

dclarizio commented Jan 10, 2018

AparnaKarve commented Jan 10, 2018

himdel commented Jan 11, 2018

himdel commented Jan 11, 2018

himdel Jan 11, 2018 •

edited

Loading

himdel Jan 11, 2018 •

edited

Loading

evertmulder Jan 31, 2018

himdel commented Jan 11, 2018 •

edited

Loading

evertmulder commented Jan 11, 2018 •

edited

Loading

evertmulder commented Jan 12, 2018

AparnaKarve commented Jan 12, 2018

evertmulder commented Jan 15, 2018 •

edited

Loading

agrare commented Jan 18, 2018

agrare commented Jan 18, 2018

martinpovolny commented Jan 19, 2018

agrare left a comment

himdel commented Jan 24, 2018

evertmulder commented Jan 24, 2018 •

edited

Loading

himdel commented Jan 30, 2018

miq-bot commented Jan 31, 2018

evertmulder commented Feb 9, 2018

himdel commented Feb 12, 2018

himdel commented Feb 14, 2018

simaishi commented Jun 1, 2018

himdel commented Jun 1, 2018

simaishi commented Jun 1, 2018

simaishi commented Jun 1, 2018

Resize disk reconfigure screen #3128

Resize disk reconfigure screen #3128

Conversation

evertmulder commented Dec 21, 2017 • edited by himdel Loading

martinpovolny commented Dec 23, 2017

gmcculloug commented Jan 10, 2018

dclarizio commented Jan 10, 2018

AparnaKarve commented Jan 10, 2018

himdel commented Jan 11, 2018

himdel commented Jan 11, 2018

himdel Jan 11, 2018 • edited Loading

Choose a reason for hiding this comment

himdel Jan 11, 2018 • edited Loading

Choose a reason for hiding this comment

evertmulder Jan 31, 2018

Choose a reason for hiding this comment

himdel commented Jan 11, 2018 • edited Loading

evertmulder commented Jan 11, 2018 • edited Loading

evertmulder commented Jan 12, 2018

AparnaKarve commented Jan 12, 2018

evertmulder commented Jan 15, 2018 • edited Loading

agrare commented Jan 18, 2018

agrare commented Jan 18, 2018

martinpovolny commented Jan 19, 2018

agrare left a comment

Choose a reason for hiding this comment

himdel commented Jan 24, 2018

evertmulder commented Jan 24, 2018 • edited Loading

himdel commented Jan 30, 2018

miq-bot commented Jan 31, 2018

evertmulder commented Feb 9, 2018

himdel commented Feb 12, 2018

himdel commented Feb 14, 2018

simaishi commented Jun 1, 2018

himdel commented Jun 1, 2018

simaishi commented Jun 1, 2018

simaishi commented Jun 1, 2018

evertmulder commented Dec 21, 2017 •

edited by himdel

Loading

himdel Jan 11, 2018 •

edited

Loading

himdel Jan 11, 2018 •

edited

Loading

himdel commented Jan 11, 2018 •

edited

Loading

evertmulder commented Jan 11, 2018 •

edited

Loading

evertmulder commented Jan 15, 2018 •

edited

Loading

evertmulder commented Jan 24, 2018 •

edited

Loading