Load Lans efficiently in ProvisionWorkflow #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
force-pushed
the
faster_lan_lookup_in_provision_virt_workflow
branch
from
36bafd8
to
0164087
Compare
NickLaMuro
force-pushed
the
faster_lan_lookup_in_provision_virt_workflow
branch
from
0164087
to
69673af
Compare
Instead of preloading Lan records, splitting them up based on if they are shareable and instantiating entire ActiveRecord instances to only use the name column in a hash, use a specific query to gather and filter those values and generate a hash from that.
|
Checked commit NickLaMuro@69673af with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
approved these changes
May 18, 2018
agrare
approved these changes
May 18, 2018
agrare
added a commit
that referenced
this pull request
May 18, 2018
…n_virt_workflow Load Lans efficiently in ProvisionWorkflow
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
[Changelog] Update for Sprint 79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of preloading Lan records, splitting them up based on if they are shareable and instantiating entire
ActiveRecordinstances to only use the name column in a hash, use a specific query to gather and filter those values and generate a hash from that.IMPORTANT NOTE: There will be a PR on
ManageIQ/manageiqthat will remove the preloading inapp/models/miq_provision_virt_workflow.rbthat this relied on to avoid an N+1. The idea is that we would merge any provider PRs first, and then the fix in the main repo so the performance impact during this is minimal.Benchmarks
Since this is part of a multi-PR fix, benchmarks will be displayed in the main PR in the
ManageIQ/manageiqrepo. Links to the related PRs will be posted down below when available.Links