Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage parsing to use datastore url #256

Merged
merged 1 commit into from
May 14, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented May 9, 2018

Fix the storage parser to use the datastore location as the manager_ref
not the managed object reference.

Depends on: #255, #258

@agrare agrare force-pushed the datastore_url branch 4 times, most recently from c9ee232 to 42286d3 Compare May 14, 2018 14:09
@agrare agrare closed this May 14, 2018
@agrare agrare reopened this May 14, 2018
@miq-bot
Copy link
Member

miq-bot commented May 14, 2018

This pull request is not mergeable. Please rebase and repush.

Fix the storage parser to use the datastore location as the manager_ref
not the managed object reference.
@miq-bot
Copy link
Member

miq-bot commented May 14, 2018

Checked commit agrare@7c0a965 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ladas Ladas merged commit 11058cd into ManageIQ:master May 14, 2018
@Ladas Ladas added this to the Sprint 86 Ending May 21, 2018 milestone May 14, 2018
@agrare agrare deleted the datastore_url branch May 14, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants