Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change custom_attributes, hosts_guest_devices and host_system_services according to core #303

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Jul 20, 2018

Inventory collection definitions changes:
custom_attributes -> ems_custom_attributes
host_guest_devices and host_system_services moved to core

Cc @agrare @Ladas

@agrare agrare self-assigned this Jul 20, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 20, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Jul 20, 2018

Checked commit slemrmartin@b81a57f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup @slemrmartin

@agrare agrare merged commit b81a57f into ManageIQ:master Jul 20, 2018
agrare added a commit that referenced this pull request Jul 20, 2018
Change custom_attributes, hosts_guest_devices and host_system_services according to core
@agrare agrare added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 20, 2018
@slemrmartin slemrmartin deleted the ic-infra-definitions branch July 23, 2018 11:56
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
…miqprovision

Email instances for Infra VM provisioning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants