Add host_guest_devices association and inv_collection #17505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
agrare
added a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Jun 28, 2018
Remove after ManageIQ/manageiq#17505 is merged
agrare
added a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Jun 28, 2018
Remove after ManageIQ/manageiq#17505 is merged
agrare
added a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Jun 28, 2018
Remove after ManageIQ/manageiq#17505 is merged
agrare
added a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Jun 28, 2018
Remove after ManageIQ/manageiq#17505 is merged
agrare
force-pushed
the
add_host_guest_devices
branch
from
2693c24
to
e556b0a
Compare
slemrmartin
reviewed
Jul 20, 2018
| @@ -24,6 +24,14 @@ def guest_devices | |||
| ) | |||
| end | |||
|
|
|||
| def host_guest_devices | |||
There was a problem hiding this comment.
if this PR will be merged before https://github.com/ManageIQ/manageiq-providers-vmware/pull/299/files#diff-d1d21103659304033655618595a1b7feR85, it should be removed from vmware's PR
Add the host_guest_devices association and inventory collection for graph refresh.
agrare
force-pushed
the
add_host_guest_devices
branch
from
e556b0a
to
9a5ec30
Compare
|
ping @blomquisg |
|
Checked commits agrare/manageiq@b528ade~...9a5ec30 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
slemrmartin
reviewed
Jul 20, 2018
| @@ -32,6 +40,14 @@ def host_hardwares | |||
| ) | |||
| end | |||
|
|
|||
| def host_system_services | |||
There was a problem hiding this comment.
@agrare 👍 - I'll wait with my PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the host_guest_devices association and inventory collection for
graph refresh.