Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow folder as refresh target #32

Merged
merged 7 commits into from
Apr 24, 2017
Merged

Allow folder as refresh target #32

merged 7 commits into from
Apr 24, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented Mar 22, 2017 •
edited
Loading

This allows an EmsFolder to be the target of a VMware refresh and will return all parents in filter_vc_data
Also this will parse the ObjUpdate events from the VimBroker and return a format suitable for save_ems_inventory.

@agrare agrare mentioned this pull request Mar 22, 2017
Merged
@agrare agrare force-pushed the folder_targeted_refresh branch 6 times, most recently from cc22141 to 0292937 Compare March 29, 2017 18:57
@agrare agrare changed the title [WIP] Allow folder as refresh target Allow folder as refresh target Apr 5, 2017
@blomquisg blomquisg requested a review from durandom April 6, 2017 19:51
durandom
durandom approved these changes Apr 12, 2017
View reviewed changes
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/models/manageiq/providers/vmware/infra_manager/event_parser.rb Outdated
obj_type = event[:objType]

method = "#{obj_type.downcase}_update_to_hash"
send(method, event) if respond_to?(method)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be public_send?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it can, done

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

Checked commits agrare/manageiq-providers-vmware@4950d43~...4cf81e2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. ⭐

@blomquisg blomquisg merged commit fe45b7c into ManageIQ:master Apr 24, 2017
@blomquisg blomquisg added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 24, 2017
@agrare agrare deleted the folder_targeted_refresh branch April 24, 2017 13:45
@agrare
Copy link
Member Author

agrare commented Apr 25, 2017

Euwe BZ https://bugzilla.redhat.com/show_bug.cgi?id=1445318

simaishi pushed a commit that referenced this pull request Apr 25, 2017
@blomquisg @simaishi
Merge pull request #32 from agrare/folder_targeted_refresh
e1709ac 
Allow folder as refresh target
(cherry picked from commit fe45b7c)

https://bugzilla.redhat.com/show_bug.cgi?id=1445311
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit e1709accc9f997dac0488a0ee45dc7554d96ab82
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Mon Apr 24 09:38:29 2017 -0400

    Merge pull request #32 from agrare/folder_targeted_refresh
    
    Allow folder as refresh target
    (cherry picked from commit fe45b7ccfa2c92daf40cc6b06e19684e58b8d0e7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445311

@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 80f832f9b018ea33d4a7c93a2964c07cb308c811
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Mon Apr 24 09:38:29 2017 -0400

    Merge pull request #32 from agrare/folder_targeted_refresh
    
    Allow folder as refresh target
    (cherry picked from commit fe45b7ccfa2c92daf40cc6b06e19684e58b8d0e7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445318

@simaishi simaishi mentioned this pull request May 11, 2017
Merged
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
@mkanoor
Merge pull request ManageIQ#32 from billfitzgerald0120/ansible_fix_sp…
7cd0308 
…ecs2

Automate - Updated failing ansible tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durandom durandom durandom approved these changes

Assignees

@blomquisg blomquisg

Labels
enhancement euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agrare @miq-bot @simaishi @durandom @blomquisg