Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ems_ref_obj to VMware folder spec factories #14462

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Add ems_ref_obj to VMware folder spec factories #14462

merged 1 commit into from
Mar 22, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented Mar 22, 2017

Add ems_ref_obj to the VMware EmsFolder factories so that they can be used in tests of code that rely on having an ems_ref_obj

Specifically this new test testing filter_vc_data which uses the ems_ref_obj here

@Fryguy Fryguy self-assigned this Mar 22, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 22, 2017

Checked commit agrare@c31020d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@Fryguy Fryguy merged commit 8dd095d into ManageIQ:master Mar 22, 2017
@Fryguy Fryguy added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 22, 2017
@agrare agrare deleted the add_ems_ref_obj_to_ems_folder_factories branch March 22, 2017 18:59
simaishi pushed a commit that referenced this pull request May 11, 2017
@Fryguy @simaishi
Merge pull request #14462 from agrare/add_ems_ref_obj_to_ems_folder_f…
9d0c58f 
…actories

Add ems_ref_obj to VMware folder spec factories
(cherry picked from commit 8dd095d)
@simaishi
Copy link
Contributor

Needed by ManageIQ/manageiq-providers-vmware#32

Euwe backport details:

$ git log -1
commit 9d0c58f9899d90edd852b4317b2e05e210965a84
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Mar 22 14:57:06 2017 -0400

    Merge pull request #14462 from agrare/add_ems_ref_obj_to_ems_folder_factories
    
    Add ems_ref_obj to VMware folder spec factories
    (cherry picked from commit 8dd095d491e7d9d5703ba0a37d0e086005d4710f)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

Assignees

@Fryguy Fryguy

Labels
euwe/backported providers/infrastructure test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @miq-bot @simaishi @Fryguy