Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set vm_or_template.connection_state #338

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 16, 2018

Instead of defaulting to nil always set vm_or_template.connection_state

Instead of defaulting to nil always set vm_or_template.connection_state
@miq-bot
Copy link
Member

miq-bot commented Nov 19, 2018

Checked commit agrare@83e69d0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ladas Ladas merged commit 320ba06 into ManageIQ:master Nov 20, 2018
@Ladas Ladas added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 20, 2018
@agrare agrare deleted the always_set_connection_state branch January 31, 2019 18:36
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
…tes_for_pre_post_actions

Add extra empty states to allow pre and post states.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants