Default connection_status to connected

[kbrock]

For most providers, connection_status is populated
For cloud providers, it is sometimes left to be nil.
Since it doesn't make sense.

But nil for them actually mean connected.

So this changes what nil means.
We're also modifying the parsers for the providers to the nil
will not get into the database.

Related to:

• https://bugzilla.redhat.com/show_bug.cgi?id=1649403
• Cloud VM should be marked as connected by default #18213
• Always set vm_or_template.connection_state manageiq-providers-vmware#338
• Always set vm_or_template.connection_state manageiq-providers-google#81
• Always set vm_or_template.connection_state manageiq-providers-azure#307
• Always set vm_or_template.connection_state manageiq-providers-amazon#500

Fixes: ManageIQ/manageiq-ui-classic#4909

/cc @agrare @miha-plesko

[miq-bot]

Checked commit kbrock@1b22b67 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

[miha-plesko]

Hm, isn't this almost the opposite of what we were talking about earlier when we said nil value should not be interpreted? I don't mind the change, but by ensuring non nullable value this patch should not be needed actually.

[kbrock]

@miha-plesko Yes, I like not interpreting nil to mean something special. @agrare modified all the parsers, and we'll need to write a migration.

In the mean time, we need to interpret nil properly.
This is what I thought @agrare wanted, but he can just close if he had other ideas in mind

[miha-plesko]

@agrare @kbrock I think we should close this PR and proceed like this:

Quickly fix Hammer issue for vCloud with minimum impact on other providers:

• Forcibly mark vCloud VMs as not disconnected manageiq-providers-vmware#339 (merge master + backport)

Properly solve the problem on master only:

• Cloud VM should be marked as connected by default #18213 (merge, no backport)
• Adam's cloud provider PRs to fix specs on providers (merge, no backport)
• cleanup cloud providers to remove def disconnected and def disconnected?

WDYT?

[agrare]

Hey @miha-plesko

Quickly fix Hammer issue for vCloud with minimum impact on other providers:

ManageIQ/manageiq-providers-vmware#339 (merge master + backport)

👍 I agree with this

Properly solve the problem on master only:

#18213 (merge, no backport)

I prefer this PR over that one because changing the default_value_for won't help for existing vms but yes I agree we should migrate nils => connected and update the parsers so we don't need this.

[kbrock]

@miha-plesko I'm concerned that the search functionality won't work because we'll be looking for cloud vms and they won't show up because nil is coded to mean disconnected (but in truth, nil means connected for cloud).

That is my driving reason for this PR and for joining this conversation

[miha-plesko]

@miq-bot remove_label hammer/yes