Forcibly mark vCloud VMs as not disconnected #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like other cloud providers we have to override functions ``` def disconnected def disconnected? ``` to always return false for vCloud cloud provider or else UI displays all its VMs as 'disconnected' regardless the actual power state. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649403 Fixes ManageIQ/manageiq-ui-classic#4909 Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
|
Checked commit miha-plesko@bb76c59 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Nov 19, 2018
|
This works for me for backport-purposes and aligns vcloud with the rest of the cloud providers |
simaishi
pushed a commit
that referenced
this pull request
Nov 19, 2018
Forcibly mark vCloud VMs as not disconnected (cherry picked from commit 1ee0757) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649403
|
Hammer backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Add a precanned physical server automation event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like other cloud providers we have to override functions
to always return false for vCloud cloud provider or else UI displays all its VMs as 'disconnected' regardless the actual power state.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649403
Fixes ManageIQ/manageiq-ui-classic#4909
@miq-bot assign @agrare
@miq-bot add_label enhancement,hammer/yes
/cc @kbrock