Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAPRINDASHVILI] Parse if a datastore is accessible from a host #359

Merged
merged 2 commits into from
Feb 11, 2019
Merged

[GAPRINDASHVILI] Parse if a datastore is accessible from a host #359

merged 2 commits into from
Feb 11, 2019

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 29, 2019

Backport of #356 overloading the host_storages.read_only column to be true if a datastore is inaccessible to bypass the schema change. Changes from the clean cherry-pick are in the second commit.

https://bugzilla.redhat.com/show_bug.cgi?id=1669583

@gmcculloug @agrare
Merge pull request ManageIQ#356 from agrare/bz_1668020_parse_datastor…
af02d2a 
…e_accessible

Parse if a datastore is accessible from a host

(cherry picked from commit 4e2e9b8)
(cherry picked from commit a6b1a65)
@agrare agrare added the bug label Jan 29, 2019
@miq-bot miq-bot changed the title [GAPRINDASHIILI] Parse if a datastore is accessible from a host [GAPRINDASHVILI] [GAPRINDASHIILI] Parse if a datastore is accessible from a host Jan 29, 2019
@agrare agrare force-pushed the gaprindashvili_bz_1669583_parse_datastore_accessible branch from 9df3bd2 to 1f7484f Compare January 29, 2019 17:13
@agrare
Overload host_storages.read_only
85362b5 
(cherry picked from commit ff712bc)
@agrare agrare force-pushed the gaprindashvili_bz_1669583_parse_datastore_accessible branch from 1f7484f to 85362b5 Compare January 29, 2019 17:46
@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2019

Checked commits agrare/manageiq-providers-vmware@af02d2a~...85362b5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 4 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

app/models/manageiq/providers/vmware/infra_manager/inventory/parser/datastore.rb

  • ❗ - Line 44, Col 22 - Rails/Presence - Use host_mount.mountInfo.accessible.presence || true instead of host_mount.mountInfo.accessible.present? ? host_mount.mountInfo.accessible : true.

spec/models/manageiq/providers/vmware/infra_manager/refresher_spec.rb

@simaishi simaishi changed the title [GAPRINDASHVILI] [GAPRINDASHIILI] Parse if a datastore is accessible from a host [GAPRINDASHVILI] Parse if a datastore is accessible from a host Feb 6, 2019
gmcculloug
gmcculloug approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simaishi simaishi merged commit 77b870b into ManageIQ:gaprindashvili Feb 11, 2019
@simaishi simaishi added this to the Sprint 105 Ending Feb 18, 2019 milestone Feb 11, 2019
@simaishi simaishi mentioned this pull request Feb 11, 2019
Merged
1 task
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
@gmcculloug
Merge pull request ManageIQ#359 from fdupont-redhat/v2v_refactor_vmtr…
a7035b7 
…ansform_method_for_ssh_support

Refactor to add support for SSH transport method
@agrare agrare deleted the gaprindashvili_bz_1669583_parse_datastore_accessible branch April 15, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@simaishi simaishi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @miq-bot @gmcculloug @simaishi