Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a HTML5 console type on top of VNC and WebMKS #409

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Jul 1, 2019

First of all, the MKS console is no longer supported so I'm dropping it completely from the codebase. Then to achieve ManageIQ/manageiq-ui-service#1520 we need to have #392 which is implemented by this PR.

The new meta console type (named HTML5) selects the right console type based on the VM's settings. According to @agrare, the operation determining the enablement of VNC is costly, so we're doing it in the background worker. The UI should ask for this new metatype only!

Closes #392
https://bugzilla.redhat.com/show_bug.cgi?id=1532720

@agrare
Copy link
Member

agrare commented Jul 1, 2019

@skateman just to make sure I got this, there are vmrc and html5 type consoles, and under html5 we have vnc and webmks?

@skateman
Copy link
Member Author

skateman commented Jul 1, 2019

@agrare yes, and also SPICE, but not for this provider

@agrare
Copy link
Member

agrare commented Jul 1, 2019

Thanks @skateman this looks good to me, we might just want to move some of the if vendor == 'vmware' supports feature checks out of core and into this repo

@skateman
Copy link
Member Author

skateman commented Jul 1, 2019

@agrare the lines you didn't like became irrelevant, so there's no need to move the deleted code 😉

@miq-bot add_label enhancement, hammer/no
@miq-bot add_reviewer @agrare

@miq-bot miq-bot requested a review from agrare July 1, 2019 20:54
@skateman skateman force-pushed the html5-console-support branch 4 times, most recently from 2ef93ae to acc44e8 Compare July 2, 2019 08:59
@skateman skateman changed the title [WIP] Create a HTML5 console type on top of VNC and WebMKS Create a HTML5 console type on top of VNC and WebMKS Jul 2, 2019
@skateman
Copy link
Member Author

skateman commented Jul 2, 2019

@agrare this is ready for review

@agrare agrare self-assigned this Jul 2, 2019
@agrare agrare merged commit 78e3358 into ManageIQ:master Jul 2, 2019
@agrare agrare added this to the Sprint 115 Ending Jul 8, 2019 milestone Jul 2, 2019
@skateman skateman deleted the html5-console-support branch July 2, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine if a given console type is supported for real
3 participants