-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a HTML5 console type on top of VNC and WebMKS #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@skateman just to make sure I got this, there are vmrc and html5 type consoles, and under html5 we have vnc and webmks? |
@agrare yes, and also SPICE, but not for this provider |
Thanks @skateman this looks good to me, we might just want to move some of the |
skateman
force-pushed
the
html5-console-support
branch
from
July 1, 2019 18:11
91e23fd
to
95ef9f3
Compare
skateman
force-pushed
the
html5-console-support
branch
4 times, most recently
from
July 2, 2019 08:59
2ef93ae
to
acc44e8
Compare
skateman
force-pushed
the
html5-console-support
branch
from
July 2, 2019 09:17
acc44e8
to
f2c87c2
Compare
skateman
changed the title
[WIP] Create a HTML5 console type on top of VNC and WebMKS
Create a HTML5 console type on top of VNC and WebMKS
Jul 2, 2019
@agrare this is ready for review |
agrare
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, the MKS console is no longer supported so I'm dropping it completely from the codebase. Then to achieve ManageIQ/manageiq-ui-service#1520 we need to have #392 which is implemented by this PR.
The new meta console type (named HTML5) selects the right console type based on the VM's settings. According to @agrare, the operation determining the enablement of VNC is costly, so we're doing it in the background worker. The UI should ask for this new metatype only!
Closes #392
https://bugzilla.redhat.com/show_bug.cgi?id=1532720