Unify the HTML5 canvas-based remote consoles under a single endpoint #18927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Jul 1, 2019
Fryguy
reviewed
Jul 1, 2019
skateman
force-pushed
the
html5-console
branch
2 times, most recently
from
7a226e0
to
cebc415
Compare
agrare
reviewed
Jul 1, 2019
|
@miq-bot add_label providers/console, enhancement, hammer/no, changelog/yes |
skateman
force-pushed
the
html5-console
branch
3 times, most recently
from
f6a2c63
to
9c098ea
Compare
skateman
changed the title
skateman
changed the title
skateman
changed the title
|
Checked commits skateman/manageiq@3c01363~...304063e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
lpichler
approved these changes
Jul 15, 2019
|
Confirming I've seen the consoles open with these changes, both in Ops UI and in SUI, connected. 👍 |
kbrock
reviewed
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had RBAC features for each remote console type separately, which is pointless as this separation is no longer behavioral. The VMRC console is no longer web-based while all the others are, it also offers way more functionalities than the others. Therefore, I'm proposing to create an RBAC feature for all the console types based on HTML5
<canvas>. They all offer the same functionality and the user doesn't really has to know which is actually running under the hood, the backend is always capable to select the best fitting one.The buttons for requesting remote consoles should follow this in the UI, i.e. one button for VMRC and another onr for HTML5-based consoles. Thanks to this it is possible to drop the global setting of a console type for VMs running on VMware providers. The console type for HTML5 will be determined by the provider upon request which will allow us for a better console support both in the ops and the service UI.
I also cleaned up the supports mixin usage in the area, now there's only a single
supports_html5_console?call instead of the separate VNC, SPICE and WebMKS ones. The conditions became much simpler and more provider agnostic.Depends on: ManageIQ/manageiq-providers-vmware#409
https://bugzilla.redhat.com/show_bug.cgi?id=1532720