Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about thick eager zero taking a while to complete #427

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Add note about thick eager zero taking a while to complete #427

merged 1 commit into from
Aug 1, 2019

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Aug 1, 2019 •
edited
Loading

Thick eager zero disk optioning, added in #385, needs a note about how long it takes per convo with Dennis and GM.

@miq-bot add_label enhancement

@miq-bot assign @agrare

Screen Shot 2019-08-01 at 2 55 41 PM

@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2019

Checked commit d-m-u@2b9772f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. ⭐

agrare
agrare approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agrare agrare merged commit 2b9772f into ManageIQ:master Aug 1, 2019
agrare added a commit that referenced this pull request Aug 1, 2019
@agrare
Merge pull request #427 from d-m-u/adding_notes_option_to_thick_eager…
49265a0 
…_zero_fields

Add note about thick eager zero taking a while to complete
@agrare agrare added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 1, 2019
@d-m-u
Copy link
Contributor Author

d-m-u commented Aug 2, 2019

@miq-bot add_label ivanchuk/yes

@simaishi
Copy link
Contributor

simaishi commented Aug 2, 2019

Ivanchuk backport details:

$ git log -1
commit 792f59b5d6b81852fb10ed72e071d5928a232534
Author: d-m-u <drewuhlmann@gmail.com>
Date:   Thu Aug 1 14:48:41 2019 -0400

    Add note about thick eager zero taking a while to complete
    
    (cherry picked from commit 2b9772f3dd49e11a5e353bb71800d777ef5ebcfa)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1633867

@kedark3 kedark3 mentioned this pull request Aug 6, 2019
Merged
@d-m-u d-m-u mentioned this pull request Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
enhancement ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-m-u @miq-bot @simaishi @agrare