Defer requirement of securerandom, use regular require #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #218 we've been seeing this warning in the console and/or rails logs:
This appears to be caused by
load
-ing securerandom after it's already beenrequire
'd somewhere else.I'm not sure why it was written this way since securerandom should already be loaded (via rails, in active_support.rb, among other places). Since it's only used within a single method, I've moved it into that method so that it's deferred until needed, and changed it to a regular
require
. The specs still seem to pass.